Update YAML Rest tests to check for product header on all responses #83290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaiera
added
>enhancement
:Core/Infra/REST API
Collaborator
|
Hi @jbaiera, I've created a changelog YAML for you. |
Member
Author
|
@elasticmachine update branch |
Member
Author
|
Fixes #82358 |
DaveCTurner
reviewed
Feb 2, 2022
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Nice catch & test idea. I left a few comments.
...org/elasticsearch/action/admin/cluster/snapshots/restore/TransportRestoreSnapshotAction.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/ccr/src/main/java/org/elasticsearch/xpack/ccr/action/TransportUnfollowAction.java
Show resolved
Hide resolved
...plugin/core/src/main/java/org/elasticsearch/xpack/core/action/TransportXPackUsageAction.java
Outdated
Show resolved
Hide resolved
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 16, 2022
…ijun/elasticsearch into fix-none-tsdb-index-dimension-tests * 'fix-none-tsdb-index-dimension-tests' of github.com:weizijun/elasticsearch: (37 commits) [docs] Mention JDK 17 in the Contributing docs (elastic#84018) Fix GeoIpDownloader startup during rolling upgrade (elastic#84000) Script: Fields API for Dense Vector (elastic#83550) Move InferenceConfigUpdate under VersionedNamedWriteable (elastic#84022) [ML] Fix license feature test cleanup (elastic#84020) Replace deprecated api in artifact transforms (elastic#84015) QL: Add leniency option to SQL CLI (elastic#83795) [Stack Monitoring] add kibana_stats version alias to -mb template (elastic#83930) Optimize spliterator for ImmutableOpenMap (elastic#83899) Feature usage actions for archive (elastic#83931) Use latch to speedup multi feature migration test (elastic#84007) Make action names available in NodeClient (elastic#83919) [DOCS] Re-add HTTP proxy setings from elastic#82737 (elastic#84001) Add CI matrix configuration for snapshot BWC versions (elastic#83990) Update YAML Rest tests to check for product header on all responses (elastic#83290) TSDB: Add time series aggs cancellation (elastic#83492) [DOCS] Fix percolate query headings (elastic#83988) [DOCS] Move tip for percolate query example (elastic#83972) Simplify LocalExporter cleaner function to fix failing tests (elastic#83812) [GCE Discovery] Correcly handle large zones with 500 or more instances (elastic#83785) ...
jbaiera
added a commit
that referenced
this pull request
Feb 16, 2022
…83290) (#83993) This PR adds assertions to YAML Rest tests to ensure that product headers are always returned in rest responses. Additional work has been included to fix a number of misuses of ThreadContext, mostly because of stashing listeners without their accompanying contexts. BWC Rest tests have been disabled for a few cases while the fixes are backported.
jbaiera
added a commit
that referenced
this pull request
Feb 16, 2022
…83290) (#83994) This PR adds assertions to YAML Rest tests to ensure that product headers are always returned in rest responses. Additional work has been included to fix a number of misuses of ThreadContext, mostly because of stashing listeners without their accompanying contexts. BWC Rest tests have been disabled for a few cases while the fixes are backported. # Conflicts: # x-pack/plugin/watcher/src/main/java/org/elasticsearch/xpack/watcher/WatcherUsageTransportAction.java
jbaiera
added a commit
that referenced
this pull request
Feb 16, 2022
…onses (#83290) (#83996) * Update YAML Rest tests to check for product header on all responses (#83290) This PR fixes a number of misuses of ThreadContext, mostly because of stashing listeners without their accompanying contexts. The YAML Rest Test changes in the original PR were not backported since they break BWC testing going further back into 7.x.
jbaiera
added a commit
that referenced
this pull request
Feb 16, 2022
This PR unmutes some tests that were muted for backporting #83290
jbaiera
added a commit
to jbaiera/elasticsearch
that referenced
this pull request
Feb 16, 2022
This PR unmutes some tests that were muted for backporting elastic#83290
jbaiera
added a commit
to jbaiera/elasticsearch
that referenced
this pull request
Feb 16, 2022
This PR unmutes some tests that were muted for backporting elastic#83290
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 16, 2022
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 16, 2022
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 22, 2022
In elastic#83290 we added an assertion that Elasticsearch returns the product header in every REST response. Unfortunately this isn't always the case, we found bugs in a couple of released versions and fixed them in elastic#84038 and elastic#84089. With this commit we skip the new assertion in the known-buggy versions. Closes elastic#84036 again.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 22, 2022
In #83290 we added an assertion that Elasticsearch returns the product header in every REST response. Unfortunately this isn't always the case, we found bugs in a couple of released versions and fixed them in #84038 and #84089. With this commit we skip the new assertion in the known-buggy versions. Closes #84036 again.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 22, 2022
In elastic#83290 we added an assertion that Elasticsearch returns the product header in every REST response. Unfortunately this isn't always the case, we found bugs in a couple of released versions and fixed them in elastic#84038 and elastic#84089. With this commit we skip the new assertion in the known-buggy versions. Closes elastic#84036 again.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 22, 2022
In elastic#83290 we added an assertion that Elasticsearch returns the product header in every REST response. Unfortunately this isn't always the case, we found bugs in a couple of released versions and fixed them in elastic#84038 and elastic#84089. With this commit we skip the new assertion in the known-buggy versions. Closes elastic#84036 again.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 22, 2022
In #83290 we added an assertion that Elasticsearch returns the product header in every REST response. Unfortunately this isn't always the case, we found bugs in a couple of released versions and fixed them in #84038 and #84089. With this commit we skip the new assertion in the known-buggy versions. Closes #84036 again.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 22, 2022
In #83290 we added an assertion that Elasticsearch returns the product header in every REST response. Unfortunately this isn't always the case, we found bugs in a couple of released versions and fixed them in #84038 and #84089. With this commit we skip the new assertion in the known-buggy versions. Closes #84036 again.
probakowski
pushed a commit
to probakowski/elasticsearch
that referenced
this pull request
Feb 23, 2022
This PR unmutes some tests that were muted for backporting elastic#83290
probakowski
pushed a commit
to probakowski/elasticsearch
that referenced
this pull request
Feb 23, 2022
In elastic#83290 we added an assertion that Elasticsearch returns the product header in every REST response. Unfortunately this isn't always the case, we found bugs in a couple of released versions and fixed them in elastic#84038 and elastic#84089. With this commit we skip the new assertion in the known-buggy versions. Closes elastic#84036 again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been discovered that a number of responses from Elasticsearch do not contain the required product header. This PR updates the tests to check for the product header on all responses from YAML Rest tests.