Skip to content

Don't Parse Monitoring Templates on Every CS Update #82203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2022
Merged

Don't Parse Monitoring Templates on Every CS Update #82203

merged 1 commit into from
Jan 4, 2022

Conversation

@original-brownbear
Copy link
Contributor

@original-brownbear original-brownbear commented Jan 4, 2022 •
edited
Loading

Same as #80086 fixing the monitoring templates which that original
PR forgot (after fixing a bunch of other things recently this is 5% of the applier runtime when creating indices in a hot loop at the moment).

Relates #77466

@original-brownbear
Don't Parse Monitoring Templates on Every CS Update
4227f0a 
Same as elastic#80086 fixing the monitoring templates which that original
PR forgot.

Relates elastic#77466
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jan 4, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 4, 2022

Pinging @elastic/es-data-management (Team:Data Management)

martijnvg
martijnvg approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@original-brownbear
Copy link
Contributor Author

original-brownbear commented Jan 4, 2022

Thanks Martijn!

@original-brownbear original-brownbear merged commit c6786dc into elastic:master Jan 4, 2022
@original-brownbear original-brownbear deleted the cache-composable-index-template-configs branch January 4, 2022 16:18
astefan pushed a commit to astefan/elasticsearch that referenced this pull request Jan 7, 2022
@original-brownbear @astefan
Don't Parse Monitoring Templates on Every CS Update (elastic#82203)
c30119b 
Same as elastic#80086 fixing the monitoring templates which that original
PR forgot.

Relates elastic#77466
astefan pushed a commit to astefan/elasticsearch that referenced this pull request Jan 7, 2022
@original-brownbear @astefan
Don't Parse Monitoring Templates on Every CS Update (elastic#82203)
436a1c1 
Same as elastic#80086 fixing the monitoring templates which that original
PR forgot.

Relates elastic#77466
@original-brownbear original-brownbear restored the cache-composable-index-template-configs branch April 18, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martijnvg martijnvg martijnvg approved these changes

Assignees

No one assigned

Labels

:Data Management/Monitoring >non-issue Team:Data Management Meta label for data/management team v8.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@original-brownbear @elasticmachine @martijnvg @pugnascotia