Fix IndexTemplateRegistry Deserializing Templates etc. During CS Updates #80086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This showed up pretty hot in profiling CS updates for many shards. We are loading+deserializing lifecycle policies and composable index templates on every CS update which gets expensive when you do a lot of them and needlessly duplicates the objects as well. Also, just throwing an unchecked exception on failure to deserialize one of these static resources seems broken as that's always a bug. This PR moves all these things to just be statically loaded on classload and makes the index template registry not show up in profiling CS updates any longer.
original-brownbear
added
>refactoring
:Data Management/ILM+SLM
elasticmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Contributor
Author
|
Thanks Martijn! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jan 4, 2022
Same as elastic#80086 fixing the monitoring templates which that original PR forgot. Relates elastic#77466
original-brownbear
added a commit
that referenced
this pull request
Jan 4, 2022
astefan
pushed a commit
to astefan/elasticsearch
that referenced
this pull request
Jan 7, 2022
Same as elastic#80086 fixing the monitoring templates which that original PR forgot. Relates elastic#77466
astefan
pushed a commit
to astefan/elasticsearch
that referenced
this pull request
Jan 7, 2022
Same as elastic#80086 fixing the monitoring templates which that original PR forgot. Relates elastic#77466
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This showed up pretty hot in profiling CS updates for many shards. We are loading+deserializing
lifecycle policies and composable index templates on every CS update which gets expensive
when you do a lot of them and needlessly duplicates the objects as well.
Also, just throwing an unchecked exception on failure to deserialize one of these static resources
seems broken as that's always a bug.
This PR moves all these things to just be statically loaded on classload and makes the index template
registry not show up in profiling CS updates any longer.
Had to move around a couple of things (name SLM code from core to the ILM plugin) for this to work. These moves seem to be a reasonable fix in isolation even though, as we did depend on core ILM to parse the template in the ILM module but didn't have a hard dependency on it there.
relates #77466