Move index.hidden from Static to Dynamic settings
#77218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setting `index.hidden` was originally implemented as a static setting, but when it was converted to be a dynamic setting, the docs were never updated to reflect that. This commit moves the docs for `index.hidden` from the section for static settings to the section for dynamic settings.
gwbrown
added
>docs
elasticmachine
added
Team:Core/Infra
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Collaborator
|
Pinging @elastic/es-docs (Team:Docs) |
lockewritesdocs
requested review from
lockewritesdocs
and removed request for
jrodewig
lockewritesdocs
approved these changes
Sep 3, 2021
Contributor
lockewritesdocs
left a comment
lockewritesdocs
left a comment
There was a problem hiding this comment.
LGTM 👍 thanks for catching this issue and fixing it @gwbrown!
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Sep 3, 2021
The setting `index.hidden` was originally implemented as a static setting, but when it was converted to be a dynamic setting, the docs were never updated to reflect that. This commit moves the docs for `index.hidden` from the section for static settings to the section for dynamic settings.
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Sep 3, 2021
The setting `index.hidden` was originally implemented as a static setting, but when it was converted to be a dynamic setting, the docs were never updated to reflect that. This commit moves the docs for `index.hidden` from the section for static settings to the section for dynamic settings.
Collaborator
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 3, 2021
The setting `index.hidden` was originally implemented as a static setting, but when it was converted to be a dynamic setting, the docs were never updated to reflect that. This commit moves the docs for `index.hidden` from the section for static settings to the section for dynamic settings.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 3, 2021
The setting `index.hidden` was originally implemented as a static setting, but when it was converted to be a dynamic setting, the docs were never updated to reflect that. This commit moves the docs for `index.hidden` from the section for static settings to the section for dynamic settings.
wjp719
added a commit
to wjp719/elasticsearch
that referenced
this pull request
Sep 4, 2021
* master: (128 commits) Mute DieWithDignityIT (elastic#77283) Fix randomization in MlNodeShutdownIT (elastic#77281) Add target_node_name for REPLACE shutdown type (elastic#77151) [DOCS] Adds information about version compatibility headers (elastic#77096) Fix template equals when mappings are wrapped (elastic#77008) Fix TextFieldMapper Retaining a Reference to its Builder (elastic#77251) Move die with dignity to be a test module (elastic#77136) Update task names for rest compatiblity (elastic#75267) [ML] adjusting bwc serialization for elastic#77256 (elastic#77257) Move `index.hidden` from Static to Dynamic settings (elastic#77218) Handle cgroups v2 in `OsProbe` (elastic#77128) Choose postings format from FieldMapper instead of MappedFieldType (elastic#77234) Add segment sorter for data streams (elastic#75195) Update skip after backport (elastic#77212) [ML] adding new defer_definition_decompression parameter to put trained model API (elastic#77189) [ML] Fix bug in inference stats persister for when feature reset is called Only check replicas in cancelling existing recoveries. (elastic#60564) Format `AbstractFilteringTestCase` (elastic#77217) [DOCS] Fixes line breaks. (elastic#77248) Convert 'routing' values in REST API tests to strings ... # Conflicts: # server/src/main/java/org/elasticsearch/cluster/metadata/DataStream.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setting
index.hiddenwas originally implemented as a staticsetting, but when it was converted to be a dynamic setting (see
#52772), the docs were never updated to reflect that.
This commit moves the docs for
index.hiddenfrom the section forstatic settings to the section for dynamic settings.