Update task names for rest compatiblity #75267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
mark-vieira
requested changes
Jul 21, 2021
Contributor
mark-vieira
left a comment
mark-vieira
left a comment
There was a problem hiding this comment.
Can we change yamlRestTestV7Compat to yamlRestTestV7CompatTest? Generally the convention is that tasks that execute tests have a "test" suffix. This still aligns well (if not better) with the convention of yamlRestTestV7CompatTransform as well.
breskeby
approved these changes
Aug 4, 2021
Contributor
breskeby
left a comment
breskeby
left a comment
There was a problem hiding this comment.
Lgtm once marks comment is Adressed and conflicts are resolved
Contributor
Author
|
@mark-vieira - mind taking another look ? The names have been updated. |
wjp719
added a commit
to wjp719/elasticsearch
that referenced
this pull request
Sep 4, 2021
* master: (128 commits) Mute DieWithDignityIT (elastic#77283) Fix randomization in MlNodeShutdownIT (elastic#77281) Add target_node_name for REPLACE shutdown type (elastic#77151) [DOCS] Adds information about version compatibility headers (elastic#77096) Fix template equals when mappings are wrapped (elastic#77008) Fix TextFieldMapper Retaining a Reference to its Builder (elastic#77251) Move die with dignity to be a test module (elastic#77136) Update task names for rest compatiblity (elastic#75267) [ML] adjusting bwc serialization for elastic#77256 (elastic#77257) Move `index.hidden` from Static to Dynamic settings (elastic#77218) Handle cgroups v2 in `OsProbe` (elastic#77128) Choose postings format from FieldMapper instead of MappedFieldType (elastic#77234) Add segment sorter for data streams (elastic#75195) Update skip after backport (elastic#77212) [ML] adding new defer_definition_decompression parameter to put trained model API (elastic#77189) [ML] Fix bug in inference stats persister for when feature reset is called Only check replicas in cancelling existing recoveries. (elastic#60564) Format `AbstractFilteringTestCase` (elastic#77217) [DOCS] Fixes line breaks. (elastic#77248) Convert 'routing' values in REST API tests to strings ... # Conflicts: # server/src/main/java/org/elasticsearch/cluster/metadata/DataStream.java
jakelandis
added a commit
that referenced
this pull request
Oct 12, 2021
This commit changes the sourceset name for REST API compatility testing
from yamlRestCompatTest to yamlRestTestV(N)Compat where (N) is the version
from which the tests are sourced. For example yamlRestTestV7Compat
or yamlRestTestV8Compat.
Two motivating reasons for this change.
consitent naming - all compatible rest testing will now use a common
prefix of yamlRestTestV7Compat where the task name to execute is
yamlRestTestV7CompatTestand the transformation task is yamlRestTestV7CompatTransform
It makes sense that corresponding source set follows this convention.
Better support when the major version changes. Gradle uses the source
set under the covers to execute the compatiblity tests. However, a user
can add custom REST tests to this source set. By using dynamically named
source sets, there should little concern of accidentally running the wrong
version tests. Additionaly it is visualy easy to tell which version the tests are
from.
This commit also removes the unecessary duplicated v7compat directory
and adds a duplicate checks to ensure that warn if there are
duplicate test names.
related: #75267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates two task names:
7is the N-1 version and calculated, such that when8isN-1 version the task names will be
yamlRestTestV8CompatTestandyamlRestTestV8CompatTransformThe motivation for
yamlRestCompatTest -> yamlRestTestV7CompatTestis thatmany projects have configured
yamlRestCompatTestbut that configuration is specific to the N-1 version. For example,
if we black list tests when running compatibility with v7, we don't also
want to blacklist those tests when running compatibility with v8.
By introducing a version-specific identifier in the name, the task will not
even exist when bumping the version creating the need to (correctly) remove
the version-specific condition.
The motivation for
transformV7RestTests -> yamlRestTestV7CompatTransformis to provide more consistent naming.
The idea behind the naming is the main task people
are likely familiar with is :
yamlRestTestso we will use that as a base.yamlRestTestV7CompatTestto run the version-specific compat testsyamlRestTestV7CompatTransformto run the version-specific transformations for the compat testsCI should be un-effected since since we introduced a lifecycle task
name
checkRestCompatwhich is what CI should be configured to use.