Skip to content

Fix the error message for instance methods that don't exist #76512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Fix the error message for instance methods that don't exist #76512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...painless/src/main/java/org/elasticsearch/painless/phase/DefaultSemanticAnalysisPhase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1769,7 +1769,7 @@ public void visitCallLocal(ECallLocal userCallLocalNode, SemanticScope semanticS

if (instanceBinding == null) {
throw userCallLocalNode.createError(new IllegalArgumentException(
"Unknown call [" + methodName + "] with [" + userArgumentNodes + "] arguments."));
"Unknown call [" + methodName + "] with [" + userArgumentsSize + "] arguments."));
}
}
}
Expand Down
7 changes: 7 additions & 0 deletions modules/lang-painless/src/test/java/org/elasticsearch/painless/WhenThingsGoWrongTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,4 +850,11 @@ public void testInvalidNullSafeBehavior() {
exec("def test = ['hostname': 'somehostname']; test?.hostname && params.host.hostname != ''"));
expectScriptThrows(NullPointerException.class, () -> exec("params?.host?.hostname && params.host?.hostname != ''"));
}

public void testInstanceMethodNotFound() {
IllegalArgumentException iae = expectScriptThrows(IllegalArgumentException.class, () -> exec("doesNotExist()"));
assertEquals(iae.getMessage(), "Unknown call [doesNotExist] with [0] arguments.");
iae = expectScriptThrows(IllegalArgumentException.class, () -> exec("doesNotExist(1, 'string', false)"));
assertEquals(iae.getMessage(), "Unknown call [doesNotExist] with [3] arguments.");
}
}