Skip to content

Conversation

@jdconrad
Copy link
Contributor

This fixes the error message in Painless for when an instance-style method isn't found. It now prints the number of arguments instead of the memory location of the nodes data structure.

@jdconrad jdconrad added >bug :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v8.0.0 auto-backport Automatically create backport pull requests when merged v7.14.1 v7.15.0 labels Aug 13, 2021
@jdconrad jdconrad requested a review from stu-elastic August 13, 2021 18:23
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Aug 13, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@jdconrad jdconrad removed the request for review from stu-elastic August 13, 2021 18:51
Copy link
Contributor

@stu-elastic stu-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way better.

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdconrad
Copy link
Contributor Author

Thanks @stu-elastic and @rjernst for the reviews!

@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
7.14 Commit could not be cherrypicked due to conflicts
7.x

To backport manually run backport --upstream elastic/elasticsearch --pr 76512

jdconrad added a commit to jdconrad/elasticsearch that referenced this pull request Aug 16, 2021
…76512)

This fixes the error message in Painless for when an instance-style method isn't found. It now prints the 
number of arguments instead of the memory location of the nodes data structure.
@jdconrad jdconrad removed the v7.14.1 label Aug 16, 2021
jdconrad added a commit that referenced this pull request Aug 16, 2021
…76566)

This fixes the error message in Painless for when an instance-style method isn't found. It now prints 
the number of arguments instead of the memory location of the nodes data structure.
wjp719 added a commit to wjp719/elasticsearch that referenced this pull request Aug 17, 2021
* master: (868 commits)
  Query API key - Rest spec and yaml tests (elastic#76238)
  Delay shard reassignment from nodes which are known to be restarting (elastic#75606)
  Reenable bwc tests for elastic#76475 (elastic#76576)
  Set version to 7.15 in BWC code (elastic#76577)
  Don't remove warning headers on all failure (elastic#76434)
  Disable bwc tests for elastic#76475 (elastic#76541)
  Re-enable bwc tests (elastic#76567)
  Keep track of data recovered from snapshots in RecoveryState (elastic#76499)
  [Transform] Align transform checkpoint range with date_histogram interval for better performance (elastic#74004)
  EQL: Remove "wildcard" function (elastic#76099)
  Fix 'accept' and 'content_type' fields for search_mvt API
  Add persistent licensed feature tracking (elastic#76476)
  Add system data streams to feature state snapshots (elastic#75902)
  fix the error message for instance methods that don't exist (elastic#76512)
  ILM: Add validation of the number_of_shards parameter in Shrink Action of ILM (elastic#74219)
  remove dashboard only reserved role (elastic#76507)
  Fix Stack Overflow in UnassignedInfo in Corner Case (elastic#76480)
  Add (Extended)KeyUsage KeyUsage, CipherSuite & Protocol to SSL diagnostics (elastic#65634)
  Add recovery from snapshot to tests (elastic#76535)
  Reenable BwC Tests after elastic#76532 (elastic#76534)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged >bug :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache Team:Core/Infra Meta label for core/infra team v7.15.0 v8.0.0-alpha2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants