change that breaks BWC in CuckooFilter #73585
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
green CI is bad here |
Contributor
Author
|
@elasticmachine test this please |
2 similar comments
Contributor
Author
|
@elasticmachine test this please |
Contributor
Author
|
@elasticmachine test this please |
Contributor
Author
|
@elasticmachine test this please |
Contributor
Author
|
closed in favour of #74736 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CuckooFilter are only used in the code if we have more than 10000 terms, therefore I don't thin the logic is well exercise when running BWC test. This is a just a draft PR to check if there is any test that will detect a change that breaks BWC in this filters.