-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Upgrade to lucene-9.0.0-snapshot-32a0a16aff0 #73324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
|
Pinging @elastic/es-search (Team:Search) |
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
There are a few nocommits, but surprisingly few. Everything compiles. Still to do:
|
I think we should deprecate the |
|
Hey @romseygeek, I have been looking into the CuckooFilter issue. I think we should have our or version of PackedInts.Mutable, but before anything we need to improve our bwc testing for that part of the code. It seems it is never exercise so we can easily introduce a bug: #73585 |
|
@romseygeek We need to build a new Lucene 9.0 snapshot as the current snapshot doesn't have the version 8.9.0, which is being used in 7.14 and 7.15. |
iverase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have only reviewed the bits affected for the change on endianness of Lucene directory API. I think we should revisit the strategy on KeyStoreWrapper and MetadataStateFormat but it can be done as a follow up.
jtibshirani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked through with a focus on the new vector format. I left minor comments and also noticed we need to update LuceneFilesExtensions to contain the vector index file .vex.
It'd also be good to extend the disk usage analyzer to cover vectors, but this seems best as a follow-up.
|
|
||
| @Override | ||
| public VectorValues getVectorValues(String field) throws IOException { | ||
| return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems best to throw UnsupportedOperationException here.
|
|
||
| } | ||
|
|
||
| private static class FilterStoredFieldVisitor extends StoredFieldVisitor { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this new private class when we already have one in org.elasticsearch.search.internal?
dnhatn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed all files and I have a question, but changes look great.
| // needed for loading plugins which may expect the context class loader to be set | ||
| permission java.lang.RuntimePermission "setContextClassLoader"; | ||
| // needed for SPI class loading | ||
| permission java.lang.RuntimePermission "accessDeclaredMembers"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we reduce the scope of this permission?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think both of these come under the disk usage and field usage actions in #74057 |
This commit upgrades elasticsearch 8.0 to use a snapshot of
Lucene 9.0.0.