Fix scroll contexts counter in SearchService #71354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
:Search/Search
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
dnhatn
force-pushed
the
6.8-fix-scroll-context
branch
from
e18254f to
251549b
Compare
jimczi
approved these changes
Apr 7, 2021
server/src/main/java/org/elasticsearch/search/SearchService.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jim Ferenczi <[email protected]>
Member
Author
|
Thanks Jim! |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Apr 7, 2021
These assertions are introduced in elastic#71354
This was referenced Apr 7, 2021
dnhatn
added a commit
that referenced
this pull request
Apr 7, 2021
These assertions are introduced in #71354
dnhatn
added a commit
that referenced
this pull request
Apr 7, 2021
These assertions are introduced in #71354
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the backport of #53449 to 6.8 and 7.6.2 weren't correct. The scroll context counter can be negative even become
Integer.MAX_VALUEafter handling many search requests. This bug causes two issues:This bug was already fixed in 7.7 and later. I will add the assertions in this PR to 7.x and master.
Kudos to @jerryjune for this finding.
Closes #56202