Fix concurrent requests race over scroll context limit #53449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>bug
:Search/Search
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
Member
Author
@elasticmachine run elasticsearch-ci/2 |
Member
Author
|
Thanks Jim. |
dnhatn
added a commit
that referenced
this pull request
Mar 12, 2020
Concurrent search scroll requests can lead to more scroll contexts than the limit.
dnhatn
added a commit
that referenced
this pull request
Mar 13, 2020
Concurrent search scroll requests can lead to more scroll contexts than the limit.
dnhatn
added a commit
that referenced
this pull request
Mar 13, 2020
Concurrent search scroll requests can lead to more scroll contexts than the limit.
dnhatn
added a commit
that referenced
this pull request
Apr 7, 2021
The scroll context counter can be negative even become Integer.MAX_VALUE after handling many search requests. This bug causes two issues: - Disable the limit of open scroll contexts when the counter is negative - Prevent opening new scroll contexts when the counter is greater than the limit of open scroll contexts Relates #53449 Closes #56202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concurrent scroll search requests can lead to more scroll contexts than the limit.