Move flattened field to core. #70122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field mapper only lived in its own module so it could be licensed as x-pack basic. Now it can be moved to core, which matches its status as a core type.
jtibshirani
added
:Search Foundations/Mapping
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
| /** | ||
| * @deprecated This class exists for backwards compatibility with 7.12 only | ||
| * and should not be used for other purposes. | ||
| */ |
Contributor
There was a problem hiding this comment.
Is this class for cases when _xpack/usage API is used in a mixed 7.12 and 7.13 nodes cluster, and this 7.13 node acts as a coordinating node and it needs to process the usage reply from 7.12 nodes?
Contributor
Author
There was a problem hiding this comment.
Yes exactly. We took the same approach for runtime fields -- @javanna explained it nicely in the RuntimeFieldsFeatureSetUsage Javadoc.
mayya-sharipova
approved these changes
Mar 11, 2021
Contributor
mayya-sharipova
left a comment
mayya-sharipova
left a comment
There was a problem hiding this comment.
@jtibshirani Thanks, this LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports #68780 to move flattened fields to core.
It also removes flattened fields from xpack usage stats now that they live in
core. The usage stats were already removed in (#53076), but this PR was not
backported to avoid a breaking change on 7.x. We have now clarified that usage
stats updates are not considered breaking, so it is safe to backport this
change.