-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Move flattened field to core. #68780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This field mapper only lived in its own module so it could be licensed as x-pack basic. Now it can be moved to core, which matches its status as a core type.
|
Pinging @elastic/es-search (Team:Search) |
| mappers.put(TextFieldMapper.CONTENT_TYPE, TextFieldMapper.PARSER); | ||
|
|
||
| mappers.put(FieldAliasMapper.CONTENT_TYPE, new FieldAliasMapper.TypeParser()); | ||
| mappers.put(FlattenedFieldMapper.CONTENT_TYPE, FlattenedFieldMapper.PARSER); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I added FlattenedFieldMapper and tried to alphabetize the entries.
This is required because in previous versions, 'flattened' is not in core.
|
A couple notes:
|
mayya-sharipova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jtibshirani, makes sense. +1 for a new package mapper.flattened.
One extra question I have, do we want to remove x-pack reference in docs/reference/mapping/types/flattened.asciidoc as well?
| - skip: | ||
| version: " - 7.2.99" | ||
| reason: "Flattened fields were implemented in 7.3." | ||
| version: " - 7.99.99" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version change because some nodes may not have x-pack installed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These core REST tests generally do not run with x-pack installed. So I bumped the version here, and plan to adjust to cover 7.12 once it's backported.
I think it makes sense to remove this, I pushed a new commit. Thanks for the review. Before merging I'd like to get more clarity on our overall design (for example when should a field type live in core vs. mapper-extras?) I'll loop back here with conclusions. |
|
I caught up with some others, and the exact design of where different mappers should live is still up for discussion. However I think we can proceed with moving flattened to core -- it has benefits and makes more sense than having it in its own module. |
This field mapper only lived in its own module so it could be licensed as x-pack
basic. Now it can be moved to core, which matches its status as a core type.
This commit doesn't bring major code simplification yet, but it does improve
how the tests are factored.