Skip to content

Conversation

@dnhatn
Copy link
Member

@dnhatn dnhatn commented Dec 11, 2020

This commit supports canceling cross-clusters search requests. Several important changes in this commit:

@dnhatn dnhatn requested review from DaveCTurner and jimczi December 11, 2020 18:52
@dnhatn dnhatn added :Distributed Coordination/Task Management Issues for anything around the Tasks API - both persistent and node level. >enhancement v8.0.0 v7.11.0 labels Dec 11, 2020
@dnhatn dnhatn marked this pull request as ready for review December 11, 2020 18:53
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Dec 11, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@dnhatn dnhatn added the :Search/Search Search-related issues that do not fall into other categories label Dec 11, 2020
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Dec 11, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@dnhatn dnhatn changed the title Support cancelling cross-clusters search requests Support canceling cross-clusters search requests Dec 11, 2020
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, thanks @dnhatn !

@dnhatn
Copy link
Member Author

dnhatn commented Dec 14, 2020

Thanks Jim!

@dnhatn dnhatn merged commit 273ac15 into elastic:master Dec 14, 2020
@dnhatn dnhatn deleted the cancel-css branch December 14, 2020 20:07
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Dec 14, 2020
This commit supports canceling cross-clusters search requests. Several
important changes in this commit:

- Set the parent task for CCS search requests
- Keep track of underlying connections instead of proxy connections
- Assign the parent task for proxy requests
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Dec 14, 2020
* elastic/master: (33 commits)
  Add searchable snapshot cache folder to NodeEnvironment (elastic#66297)
  [DOCS] Add dynamic runtime fields to docs (elastic#66194)
  Add HDFS searchable snapshot integration (elastic#66185)
  Support canceling cross-clusters search requests (elastic#66206)
  Mute testCacheSurviveRestart (elastic#66289)
  Fix cat tasks api params in spec and handler (elastic#66272)
  Snapshot of a searchable snapshot should be empty (elastic#66162)
  [ML] DFA _explain API should not fail when none field is included (elastic#66281)
  Add action to decommission legacy monitoring cluster alerts (elastic#64373)
  move rollup_index param out of RollupActionConfig (elastic#66139)
  Improve FieldFetcher retrieval of fields (elastic#66160)
  Remove unsed fields in `RestAnalyzeAction` (elastic#66215)
  Simplify searchable snapshot CacheKey (elastic#66263)
  Autoscaling remove feature flags (elastic#65973)
  Improve searchable snapshot mount time (elastic#66198)
  [ML] Report cause when datafeed extraction encounters error (elastic#66167)
  Remove suggest reference in some API specs (elastic#66180)
  Fix warning when installing a plugin for different ESversion (elastic#66146)
  [ML] make `xpack.ml.max_ml_node_size` and `xpack.ml.use_auto_machine_memory_percent` dynamically settable (elastic#66132)
  [DOCS] Add `require_alias` to Bulk API (elastic#66259)
  ...
dnhatn added a commit that referenced this pull request Dec 15, 2020
This commit supports canceling cross-clusters search requests. Several
important changes in this commit:

- Set the parent task for CCS search requests
- Keep track of underlying connections instead of proxy connections
- Assign the parent task for proxy requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Coordination/Task Management Issues for anything around the Tasks API - both persistent and node level. >enhancement :Search/Search Search-related issues that do not fall into other categories Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Search Meta label for search team v7.11.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants