move rollup_index param out of RollupActionConfig #66139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talevy
added
>non-issue
:StorageEngine/Rollup
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
talevy
force-pushed
the
extract-rollup-index
branch
from
b1412be to
156fc64
Compare
talevy
commented
Dec 10, 2020
csoulios
approved these changes
Dec 14, 2020
Contributor
csoulios
left a comment
csoulios
left a comment
There was a problem hiding this comment.
LGTM!
Removing index (both source and rollup) names from rollup confi is cleaner indeed. Thanks!
csoulios
reviewed
Dec 14, 2020
jrodewig
reviewed
Dec 14, 2020
jrodewig
approved these changes
Dec 14, 2020
This commit moves the ownership of tracking the rollup_index from the RollupActionConfig to the RollupAction.Request. This is cleaner since the config should not be concerned with the source and rollup indices. relates elastic#42720.
talevy
force-pushed
the
extract-rollup-index
branch
from
1eebd6c to
66e6940
Compare
This reverts commit 66e6940.
talevy
added a commit
that referenced
this pull request
Dec 14, 2020
This commit moves the ownership of tracking the rollup_index from the RollupActionConfig to the RollupAction.Request. This is cleaner since the config should not be concerned with the source and rollup indices. relates #42720. Co-authored-by: James Rodewig <[email protected]>
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Dec 14, 2020
* elastic/master: (33 commits) Add searchable snapshot cache folder to NodeEnvironment (elastic#66297) [DOCS] Add dynamic runtime fields to docs (elastic#66194) Add HDFS searchable snapshot integration (elastic#66185) Support canceling cross-clusters search requests (elastic#66206) Mute testCacheSurviveRestart (elastic#66289) Fix cat tasks api params in spec and handler (elastic#66272) Snapshot of a searchable snapshot should be empty (elastic#66162) [ML] DFA _explain API should not fail when none field is included (elastic#66281) Add action to decommission legacy monitoring cluster alerts (elastic#64373) move rollup_index param out of RollupActionConfig (elastic#66139) Improve FieldFetcher retrieval of fields (elastic#66160) Remove unsed fields in `RestAnalyzeAction` (elastic#66215) Simplify searchable snapshot CacheKey (elastic#66263) Autoscaling remove feature flags (elastic#65973) Improve searchable snapshot mount time (elastic#66198) [ML] Report cause when datafeed extraction encounters error (elastic#66167) Remove suggest reference in some API specs (elastic#66180) Fix warning when installing a plugin for different ESversion (elastic#66146) [ML] make `xpack.ml.max_ml_node_size` and `xpack.ml.use_auto_machine_memory_percent` dynamically settable (elastic#66132) [DOCS] Add `require_alias` to Bulk API (elastic#66259) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the ownership of tracking the rollup_index from
the RollupActionConfig to the RollupAction.Request.
This is cleaner since the config should not be concerned with the
source and rollup indices.
relates #42720.