Rename field_masking_span to make it more consistent with other span … #65787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvernum
added
the
:Search/Search
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
Contributor
|
@elasticmachine ok to test |
Author
|
I was not able to reproduce these errors on my environment, I am kinda lost on this part. Could you give me more details to run these tests locally? |
Contributor
|
Sorry for the late reply. We cannot change query names directly, the old name needs to be deprecated first. I am going to close this PR for now because it's old but don't hesitate to reopen if you'd like to continue working on this (we'll be more reactive next time). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…queries #63527
Fixes #63527 to make it more consistent as reported