[Queries] make "Span field masking" consistent with other span queries

[homersimpsons]

Request

Rename field_masking_span to span_field_masking.

Explanations

Currently the Span field masking query is the only span_* to end with _span instead of starting with span_

The query builder is coherent with this naming and should be updated accordingly

elasticsearch/server/src/main/java/org/elasticsearch/index/query/QueryBuilders.java

Line 377 in 4e740c2

public static FieldMaskingSpanQueryBuilder fieldMaskingSpanQuery(SpanQueryBuilder query, String field) {

Lucene had the right naming:

The span field masking query maps to Lucene’s SpanFieldMaskingQuery

Of course this is a Breaking Change so it should not land before 8.0.0. This is also not critical, but this could improve the naming consistence of all span queries.

[elasticmachine]

Pinging @elastic/es-search (:Search/Search)

[sabiya]

@homersimpsons I am interested to pick this.
Can I start to work on this?

[homersimpsons]

@sabiya I am sorry I was just mentioning the issue, I do not know if the search Team is willing to make this change...

[romseygeek]

@homersimpsons thanks for opening the issue. We think this is a reasonable change to make, please feel free to work on it @sabiya .

The important thing to do here will be to ensure that we maintain backwards compatibility. The simplest way forward I think will be to change the QuerySpec registration for this query to use a ParseField rather than a String for the name, and set things up so that the old name is added as a deprecated name to the ParseField.

[soarescaique]

Can I work on this? Since it's still opened?

[sabiya]

Hello @soarescaique,
I have taken this issue, was waiting for someone to confirm.
I would like to fix it. Please pick another issue.
@romseygeek on which version/branch shall I fix this?