[ML] Propagate xpack.ml.min_disk_space_off_heap to native process #64720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is the Java-side companion to elastic/ml-cpp#1556. It ensures that customisations to xpack.ml.min_disk_space_off_heap are reflected in the disk space check done in the C++ code as well as in the disk space check done in the Java code. The check done in the C++ code runs later than the check in the Java code, and only requires that 80% of the disk space required in the Java code is available. (The defaults are 5GB and 4GB.) Relates elastic/ml-cpp#1556 Closes elastic/ml-cpp#1554 Fixes elastic#58806
Collaborator
|
Pinging @elastic/ml-core (:ml) |
Author
|
This is a |
benwtrent
approved these changes
Nov 6, 2020
Author
|
@elasticmachine update branch |
droberts195
pushed a commit
to droberts195/elasticsearch
that referenced
this pull request
Nov 6, 2020
This change is the Java-side companion to elastic/ml-cpp#1556. It ensures that customisations to xpack.ml.min_disk_space_off_heap are reflected in the disk space check done in the C++ code as well as in the disk space check done in the Java code. The check done in the C++ code runs later than the check in the Java code, and only requires that 80% of the disk space required in the Java code is available. (The defaults are 5GB and 4GB.) Backport of elastic#64720
droberts195
pushed a commit
that referenced
this pull request
Nov 6, 2020
…4733) This change is the Java-side companion to elastic/ml-cpp#1556. It ensures that customisations to xpack.ml.min_disk_space_off_heap are reflected in the disk space check done in the C++ code as well as in the disk space check done in the Java code. The check done in the C++ code runs later than the check in the Java code, and only requires that 80% of the disk space required in the Java code is available. (The defaults are 5GB and 4GB.) Backport of #64720
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is the Java-side companion to elastic/ml-cpp#1556.
It ensures that customisations to xpack.ml.min_disk_space_off_heap
are reflected in the disk space check done in the C++ code as well
as in the disk space check done in the Java code. The check done
in the C++ code runs later than the check in the Java code, and
only requires that 80% of the disk space required in the Java code
is available. (The defaults are 5GB and 4GB.)
Relates elastic/ml-cpp#1556
Closes elastic/ml-cpp#1554
Fixes #58806