Skip to content

MetadataFieldMapper.Builder.build() doesn't need ContentPath #64636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2020
Merged

MetadataFieldMapper.Builder.build() doesn't need ContentPath #64636

merged 2 commits into from
Nov 5, 2020

Conversation

@romseygeek
Copy link
Contributor

@romseygeek romseygeek commented Nov 5, 2020

Metadata fields are always instantiated at the root of a document,
so they don't need to take the ContentPath in their build() methods.

Also converts a couple of metadata parsers from Configurable to
Fixed, as they don't have any parameters.

@romseygeek romseygeek added :Search Foundations/Mapping Index mappings, including merging and defining field types >refactoring v8.0.0 v7.11.0 labels Nov 5, 2020
@romseygeek romseygeek requested a review from javanna November 5, 2020 12:45
@romseygeek romseygeek self-assigned this Nov 5, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 5, 2020

Pinging @elastic/es-search (:Search/Mapping)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Nov 5, 2020
javanna
javanna approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romseygeek romseygeek merged commit 61b51ba into elastic:master Nov 5, 2020
@romseygeek romseygeek deleted the mapper/meta-builder branch November 5, 2020 15:34
romseygeek added a commit that referenced this pull request Nov 5, 2020
@romseygeek
MetadataFieldMapper.Builder.build() doesn't need ContentPath (#64636)
e3a30fc 
Metadata fields are always instantiated at the root of a document,
so they don't need to take the ContentPath in their build() methods.

Also converts a couple of metadata parsers from Configurable to
Fixed, as they don't have any parameters.
csoulios added a commit to csoulios/elasticsearch that referenced this pull request Nov 5, 2020
@csoulios
Fixed conflict introduced after merging elastic#64636
d17ee86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javanna javanna javanna approved these changes

Assignees

@romseygeek romseygeek

Labels

>refactoring :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Meta label for search team v7.11.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@romseygeek @elasticmachine @javanna @jakelandis