MetadataFieldMapper.Builder.build() doesn't need ContentPath (#64636)

Metadata fields are always instantiated at the root of a document,
so they don't need to take the ContentPath in their build() methods.

Also converts a couple of metadata parsers from Configurable to
Fixed, as they don't have any parameters.

Author: romseygeek

plugins/mapper-size/src/main/java/org/elasticsearch/index/mapper/size/SizeFieldMapper.java

@@ -20,7 +20,6 @@
 package org.elasticsearch.index.mapper.size;
 
 import org.elasticsearch.common.Explicit;
-import org.elasticsearch.index.mapper.ContentPath;
 import org.elasticsearch.index.mapper.FieldMapper;
 import org.elasticsearch.index.mapper.MappedFieldType;
 import org.elasticsearch.index.mapper.MetadataFieldMapper;
@@ -54,7 +53,7 @@ protected List<Parameter<?>> getParameters() {
         }
 
         @Override
-        public SizeFieldMapper build(ContentPath contentPath) {
+        public SizeFieldMapper build() {
             return new SizeFieldMapper(enabled.getValue(), new NumberFieldType(NAME, NumberType.INTEGER));
         }
     }

server/src/internalClusterTest/java/org/elasticsearch/index/mapper/ExternalValuesMapperIntegrationIT.java

@@ -91,8 +91,6 @@ public void testHighlightingOnCustomString() throws Exception {
     public void testExternalValues() throws Exception {
         prepareCreate("test-idx").addMapping("type",
                 XContentFactory.jsonBuilder().startObject().startObject("type")
-                .startObject(ExternalMetadataMapper.CONTENT_TYPE)
-                .endObject()
                 .startObject("properties")
                     .startObject("field").field("type", ExternalMapperPlugin.EXTERNAL).endObject()
                 .endObject()

server/src/main/java/org/elasticsearch/index/mapper/AllFieldMapper.java

@@ -68,7 +68,7 @@ protected List<Parameter<?>> getParameters() {
         }
 
         @Override
-        public AllFieldMapper build(ContentPath contentPath) {
+        public AllFieldMapper build() {
             if (enabled.getValue().value()) {
                 throw new IllegalArgumentException("[_all] is disabled in this version.");
             }

server/src/main/java/org/elasticsearch/index/mapper/FieldNamesFieldMapper.java

@@ -97,7 +97,7 @@ protected List<Parameter<?>> getParameters() {
         }
 
         @Override
-        public FieldNamesFieldMapper build(ContentPath contentPath) {
+        public FieldNamesFieldMapper build() {
             if (enabled.getValue().explicit()) {
                 deprecationLogger.deprecate("field_names_enabled_parameter", ENABLED_DEPRECATION_MESSAGE);
             }

server/src/main/java/org/elasticsearch/index/mapper/MetadataFieldMapper.java

@@ -128,7 +128,11 @@ boolean isConfigured() {
         }
 
         @Override
-        public abstract MetadataFieldMapper build(ContentPath contentPath);
+        public final MetadataFieldMapper build(ContentPath path) {
+            return build();
+        }
+
+        public abstract MetadataFieldMapper build();
     }
 
     protected MetadataFieldMapper(MappedFieldType mappedFieldType) {

server/src/main/java/org/elasticsearch/index/mapper/RoutingFieldMapper.java

@@ -71,7 +71,7 @@ protected List<Parameter<?>> getParameters() {
         }
 
         @Override
-        public RoutingFieldMapper build(ContentPath contentPath) {
+        public RoutingFieldMapper build() {
             return new RoutingFieldMapper(required.getValue());
         }
     }

server/src/main/java/org/elasticsearch/index/mapper/SourceFieldMapper.java

@@ -91,7 +91,7 @@ protected List<Parameter<?>> getParameters() {
         }
 
         @Override
-        public SourceFieldMapper build(ContentPath contentPath) {
+        public SourceFieldMapper build() {
             return new SourceFieldMapper(enabled.getValue(),
                 includes.getValue().toArray(new String[0]),
                 excludes.getValue().toArray(new String[0]));

server/src/test/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateServiceTests.java

@@ -40,7 +40,6 @@
 import org.elasticsearch.common.xcontent.XContentType;
 import org.elasticsearch.env.Environment;
 import org.elasticsearch.index.Index;
-import org.elasticsearch.index.mapper.ContentPath;
 import org.elasticsearch.index.mapper.FieldMapper;
 import org.elasticsearch.index.mapper.MappedFieldType;
 import org.elasticsearch.index.mapper.MapperParsingException;
@@ -1631,7 +1630,7 @@ protected List<FieldMapper.Parameter<?>> getParameters() {
         }
 
         @Override
-        public MetadataFieldMapper build(ContentPath contentPath) {
+        public MetadataFieldMapper build() {
             return new MetadataTimestampFieldMapper(enabled.getValue());
         }
     }

server/src/test/java/org/elasticsearch/index/mapper/ExternalMetadataMapper.java

@@ -22,11 +22,6 @@
 import org.apache.lucene.document.Field.Store;
 import org.apache.lucene.document.StringField;
 
-import java.io.IOException;
-import java.util.Collections;
-import java.util.Iterator;
-import java.util.List;
-
 public class ExternalMetadataMapper extends MetadataFieldMapper {
 
     static final String CONTENT_TYPE = "_external_root";
@@ -37,39 +32,16 @@ protected ExternalMetadataMapper() {
         super(new BooleanFieldMapper.BooleanFieldType(FIELD_NAME));
     }
 
-    @Override
-    public Iterator<Mapper> iterator() {
-        return Collections.emptyIterator();
-    }
-
     @Override
     protected String contentType() {
         return CONTENT_TYPE;
     }
 
     @Override
-    public void postParse(ParseContext context) throws IOException {
+    public void postParse(ParseContext context) {
         context.doc().add(new StringField(FIELD_NAME, FIELD_VALUE, Store.YES));
     }
 
-    public static class Builder extends MetadataFieldMapper.Builder {
-
-        protected Builder() {
-            super(FIELD_NAME);
-        }
-
-        @Override
-        protected List<Parameter<?>> getParameters() {
-            return Collections.emptyList();
-        }
-
-        @Override
-        public ExternalMetadataMapper build(ContentPath contentPath) {
-            return new ExternalMetadataMapper();
-        }
-
-    }
-
-    public static final TypeParser PARSER = new ConfigurableTypeParser(c -> new ExternalMetadataMapper(), c -> new Builder());
+    public static final TypeParser PARSER = new FixedTypeParser(c -> new ExternalMetadataMapper());
 
 }

server/src/test/java/org/elasticsearch/index/mapper/MockMetadataMapperPlugin.java

@@ -27,8 +27,6 @@
 
 import java.io.IOException;
 import java.util.Collections;
-import java.util.Iterator;
-import java.util.List;
 import java.util.Map;
 
 /**
@@ -58,37 +56,12 @@ protected void parseCreateField(ParseContext context) throws IOException {
             }
         }
 
-        @Override
-        public Iterator<Mapper> iterator() {
-            return Collections.emptyIterator();
-        }
-
         @Override
         protected String contentType() {
             return CONTENT_TYPE;
         }
 
-        public static class Builder extends MetadataFieldMapper.Builder {
-
-            protected Builder() {
-                super(FIELD_NAME);
-            }
-
-            @Override
-            protected List<Parameter<?>> getParameters() {
-                return Collections.emptyList();
-            }
-
-            @Override
-            public MockMetadataMapper build(ContentPath contentPath) {
-                return new MockMetadataMapper();
-            }
-        }
-
-        public static final TypeParser PARSER = new ConfigurableTypeParser(
-            c -> new MockMetadataMapper(),
-            c -> new MockMetadataMapper.Builder()) {
-        };
+        public static final TypeParser PARSER = new FixedTypeParser(c -> new MockMetadataMapper());
     }
 
     @Override