More resilient ILM history rollover test #61973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probakowski
added
>test
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
andreidan
reviewed
Sep 4, 2020
| SearchResponse search = client().prepareSearch(firstIndex).setQuery(matchQuery("index", firstIndex)).setSize(0).get(); | ||
| assertThat(search.getHits().getTotalHits().value, is(9L)); | ||
| } catch (Exception e) { | ||
| fail(e.getMessage()); |
Contributor
There was a problem hiding this comment.
Thanks for fixing this Przemko.
Can you add a comment on why this is needed please? it's not obvious assertBusy fails on the first non-AssertionError exception. We could also use assertHitCount maybe?
Is it worth also increasing the timeout of assertBusy to 30 seconds?
Contributor
Author
There was a problem hiding this comment.
I've added a comment and switched to assertHitCount. I don't think we need to increase timeout - we should have to wait for at most 5s for all ILM history items to be index
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
This was backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some protection in ILM history rollover test to remove its flakiness