[7.x] Move internal index templates to composable templates (#61457) #61661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves watcher, ILM history and SLM history templates to composable templates. Versions are updated to reflect the switch. Only change to the templates themselves is added `_meta` to mark them as managed
This change fixed settings accidentally changed in elastic#61457, this fixes ability of ILM history index to rollover. It also adds test to make sure we can't hit this kind of bug in the future. Closes elastic#61863
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample-windows |
1 similar comment
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample-windows |
probakowski
added
:Data Management/ILM+SLM
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Watcher) |
Contributor
Author
|
@jakelandis @andreidan I would be grateful for review on this backport as this is vastly different than the master commit |
Contributor
Author
|
I've added the fix from #61973 to this PR as well, thanks @andreidan for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: