Skip to content

Enable searchable snapshot feature for integTest clusters #61888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2020
Merged

Enable searchable snapshot feature for integTest clusters #61888

merged 1 commit into from
Sep 4, 2020

Conversation

@tlrx
Copy link
Member

@tlrx tlrx commented Sep 3, 2020

One of our build job release-tests started to fail recently on CI for integration tests of the following package:
org.elasticsearch.xpack.searchablesnapshots

Build scans:
https://gradle-enterprise.elastic.co/s/5tyix4dniwqxm
https://gradle-enterprise.elastic.co/s/ijkfq3lsqovee

I suspect that this is related to #61802, which recently change some build plugins, and the consequence is that

test {
  if (BuildParams.isSnapshotBuild() == false) {
    systemProperty 'es.searchable_snapshots_feature_enabled', 'true'
  }
}

is not applied to integration tests. Or maybe #54987 wasn't complete since the beginning.

This pull request tries to correct that.

@tlrx tlrx added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.0.0 v7.10.0 labels Sep 3, 2020
@tlrx tlrx requested a review from mark-vieira September 3, 2020 09:08
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 3, 2020

Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore)

@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Sep 3, 2020
@tlrx tlrx changed the title Enable searchable snapshot feature for all test clusters Enable searchable snapshot feature for integTest clusters Sep 3, 2020
@tlrx tlrx added the :Delivery/Build Build or test infrastructure label Sep 3, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 3, 2020

Pinging @elastic/es-core-infra (:Core/Infra/Build)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Sep 3, 2020
@tlrx tlrx removed :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Core/Infra Meta label for core/infra team labels Sep 3, 2020
@elasticmachine elasticmachine removed the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Sep 3, 2020
@tlrx tlrx mentioned this pull request Sep 3, 2020
Closed
@tlrx
Copy link
Member Author

tlrx commented Sep 3, 2020

@elasticmachine run elasticsearch-ci/packaging-sample-windows

mark-vieira
mark-vieira approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tlrx tlrx merged commit 0b7fde8 into elastic:master Sep 4, 2020
@tlrx tlrx deleted the enable-searchable_snapshots_feature_enabled branch September 4, 2020 08:24
@tlrx
Copy link
Member Author

tlrx commented Sep 4, 2020

Thanks Mark!

@tlrx tlrx mentioned this pull request Sep 4, 2020
Merged
tlrx added a commit that referenced this pull request Sep 4, 2020
@tlrx
Enable searchable snapshot feature for all test clusters (#61888) (#6…
10d14ce 
…1965)

This commit reenables the searchable snapshot feature for integration tests 
after #61802 which changed some build plugins.
@tlrx tlrx mentioned this pull request Sep 7, 2020
Closed
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mark-vieira mark-vieira mark-vieira approved these changes

Assignees

No one assigned

Labels

:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests v7.10.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tlrx @elasticmachine @mark-vieira @jakelandis