Enable searchable snapshots for release tests #54987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
:Distributed Coordination/Snapshot/Restore
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
jasontedor
approved these changes
Apr 8, 2020
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
This is the strategy we elected to use in autoscaling as well. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our searchable snapshot unit tests have been failing in release builds due to the feature toggle not being enabled.
https://gradle-enterprise.elastic.co/s/thubipxlrt4my/tests/inzjkvfxeeuik-jku4cqj6y3o3c
This enables the feature flag for these unit tests when we are doing a non-snapshot build. Not sure if this is the correct fix to be honest but we do this for the rest tests already.