Update precommit to filter out project dependencies #58189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncies (elastic#58015)"" This reverts commit e1594eb.
This reverts commit a98a297.
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
Member
Author
|
@elasticmachine update branch |
jbaiera
added a commit
to jbaiera/elasticsearch
that referenced
this pull request
Jun 25, 2020
If a project is pulling in an external org.elasticsearch dependency, the dependency report generation would require a license file for the dependency to be present. This would break precommit because a license was present that it did not feel was warranted. This un-reverts the update to the dependenciesInfo task, as well as the JNA license addition.
jbaiera
added a commit
that referenced
this pull request
Jun 25, 2020
If a project is pulling in an external org.elasticsearch dependency, the dependency report generation would require a license file for the dependency to be present. This would break precommit because a license was present that it did not feel was warranted. This un-reverts the update to the dependenciesInfo task, as well as the JNA license addition.
mark-vieira
added
Team:Delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to fix an issue introduced in #58015.
If a project is pulling in an external
org.elasticsearchdependency, the dependency report generation would require a license file for the dependency to be present. This would break precommit because a license was present that it did not feel was warranted. This un-reverts the update to the dependenciesInfo task, as well as the JNA license addition.