Make dependenciesInfo task filter out project dependencies #58015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
jbaiera
added a commit
to jbaiera/elasticsearch
that referenced
this pull request
Jun 12, 2020
…8015) By default we filter out projects from dependencies info task based on their group names. We should be filtering based on if the dependency is a project dependency.
jbaiera
added a commit
that referenced
this pull request
Jun 12, 2020
jasontedor
added a commit
that referenced
this pull request
Jun 12, 2020
Previously we excluded requiring licenses for dependencies with the group name org.elasticsearch under the assumption that these use the top-level Elasticsearch license. This is not always correct, for example, for the org.elasticsearch:jna dependency as this is merely a wrapper around the upstream JNA project, and that is the license that we should be including. A recent change modified this check from using the group name to checking only if the dependency is a project dependency. This exposed the use of JNA in SQL CLI to this check, but the license for it was not added. This commit addresses this by adding the license. Relates #58015
jasontedor
added a commit
that referenced
this pull request
Jun 12, 2020
Previously we excluded requiring licenses for dependencies with the group name org.elasticsearch under the assumption that these use the top-level Elasticsearch license. This is not always correct, for example, for the org.elasticsearch:jna dependency as this is merely a wrapper around the upstream JNA project, and that is the license that we should be including. A recent change modified this check from using the group name to checking only if the dependency is a project dependency. This exposed the use of JNA in SQL CLI to this check, but the license for it was not added. This commit addresses this by adding the license. Relates #58015
Member
|
I'm reverting this change because it broke the |
jasontedor
added a commit
that referenced
this pull request
Jun 12, 2020
Member
Member
Author
Oh woops, I definitely thought it was rolled in with |
jbaiera
added a commit
to jbaiera/elasticsearch
that referenced
this pull request
Jun 16, 2020
…ncies (elastic#58015)"" This reverts commit e1594eb.
mark-vieira
added
Team:Delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default we filter out projects from dependencies info task based on their group names. We should be filtering based on if the dependency is a project dependency.