Skip to content

Conversation

@imotov
Copy link
Contributor

@imotov imotov commented Jun 11, 2020

Adds async support to EQL searches

Closes #49638

imotov and others added 20 commits May 13, 2020 09:50
Adds support for async searches to eql search API. This commit is limited to
only submitting search API requests and doesn't provide APIs to get results
nor delete the results. These functions will be added in follow up PRs.

Relates to #49638
Switches to RestCancellableNodeClient wrapper for eql search operation in
order to detect clients closing the connection and cancelling the operation.

Relates to #49638
Adds support for retrieving async EQL search result s to eql search API.

Relates to #49638
Adds the `dev` admonition to EQL features, which are in development
under a feature flag.
Adds support for deleting async EQL search results to EQL search API.

Relates to #49638
The `size` parameter can be used to limit matching events or sequences.
The async task task maintenance service is used by both async search plugin
as well as EQL plugin. So it needs to reside in the core.

Relates to #49638
@imotov imotov added the :Analytics/EQL EQL querying label Jun 11, 2020
@imotov imotov requested review from costin and jimczi June 11, 2020 15:17
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (:Query Languages/EQL)

@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label Jun 11, 2020
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left the specific EQL part for @costin but the refactoring of the async components looks good to me. Thanks for iterating on this @imotov !

@imotov
Copy link
Contributor Author

imotov commented Jun 11, 2020

@elasticmachine update branch

@imotov
Copy link
Contributor Author

imotov commented Jun 12, 2020

@elasticmachine update branch

@imotov
Copy link
Contributor Author

imotov commented Jun 12, 2020

@elasticmachine update branch

Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imotov
Copy link
Contributor Author

imotov commented Jun 16, 2020

@elasticmachine update branch

@imotov imotov merged commit f5e6ca0 into master Jun 16, 2020
@imotov imotov deleted the feature/async-eql branch June 16, 2020 15:45
@imotov
Copy link
Contributor Author

imotov commented Jun 16, 2020

@jimczi @costin thanks a lot for reviews and guidance!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/EQL EQL querying Team:QL (Deprecated) Meta label for query languages team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make EQL REST Querying API async

6 participants