Skip to content

Conversation

@jrodewig
Copy link
Contributor

Adds documentation for the get async EQL search API.
Also updates existing docs to cross-reference the new
documentation.

Relates to #56852 and #49638.

@jrodewig jrodewig added >docs General docs changes :Analytics/EQL EQL querying labels May 29, 2020
@jrodewig jrodewig requested a review from imotov May 29, 2020 15:02
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label May 29, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (:Query Languages/EQL)

@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label May 29, 2020
@jrodewig jrodewig changed the title [DOCS] Document get async EQL search API [DOCS] EQL: Document get async EQL search API May 29, 2020
Copy link
Contributor

@imotov imotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor correction about blocked requests. Otherwise LGTM.


`wait_for_completion_timeout`::
(Optional, <<time-units,time value>>)
Timeout duration to block other requests while waiting for the request to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not quite sure what you mean by "block other requests" here. It should only block the current request. Please let me know if you observed other behavior.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're correct. Thanks for catching this. I've updated the definition with 30518af.

* An `is_partial` value of `true`, indicating the response does not contain
complete search results.
* An `is_running` value of `true`, indicating the search is async and ongoing.
* Partial search results, if available, in the `hits` property.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have this for now, but hopefully, we will have some partial results soon. So, it might make sense to leave it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave this in for now. It'll be easy to remove later if wanted.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jrodewig jrodewig merged commit 78146bb into elastic:feature/async-eql May 30, 2020
@jrodewig jrodewig deleted the docs__get-async-eql-search-api branch May 30, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/EQL EQL querying >docs General docs changes Team:Docs Meta label for docs team Team:QL (Deprecated) Meta label for query languages team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants