Skip to content

Change token for nodes stats adaptive selection submetric #54193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Change token for nodes stats adaptive selection submetric #54193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...er/src/main/java/org/elasticsearch/action/admin/cluster/node/stats/NodesStatsRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ private enum Metric {
SCRIPT("script"),
DISCOVERY("discovery"),
INGEST("ingest"),
ADAPTIVE_SELECTION("adaptiveSelection");
ADAPTIVE_SELECTION("adaptive_selection");
Copy link
Member

@rjernst rjernst Mar 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure changing this will work in 7.x, because in mixed cluster, the server/request would not align? Additionally, the transport client would have similar failure scenarios?

Copy link
Contributor Author

@williamrandolph williamrandolph Mar 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My plan is that this PR will change the token in 7.7, which will mean that 7.7.0 and all following 7.7.x releases will have the change. #53637 will make the change in master and the change will come in for 7.x in #54141. Both of those PRs are ready for merge once this issue is resolved. I believe that if we make this change on 7.7, 7.x, and master, then there won't be any releases where the versions won't align. Does that make sense? Am I missing something?

Copy link
Member

@rjernst rjernst Mar 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. I just realized where my confusion lies: I was thinking this enum existed and these strings were serialized currently, when in fact the 7.6 and before request is serialized with boolean flags.


private String metricName;

Expand Down