Change token for nodes stats adaptive selection submetric #54193
Conversation
williamrandolph
added
>non-issue
:Core/Infra/Plugins
|
Pinging @elastic/es-core-infra (:Core/Infra/Plugins) |
| DISCOVERY("discovery"), | ||
| INGEST("ingest"), | ||
| ADAPTIVE_SELECTION("adaptiveSelection"); | ||
| ADAPTIVE_SELECTION("adaptive_selection"); |
There was a problem hiding this comment.
I'm not sure changing this will work in 7.x, because in mixed cluster, the server/request would not align? Additionally, the transport client would have similar failure scenarios?
There was a problem hiding this comment.
My plan is that this PR will change the token in 7.7, which will mean that 7.7.0 and all following 7.7.x releases will have the change. #53637 will make the change in master and the change will come in for 7.x in #54141. Both of those PRs are ready for merge once this issue is resolved. I believe that if we make this change on 7.7, 7.x, and master, then there won't be any releases where the versions won't align. Does that make sense? Am I missing something?
There was a problem hiding this comment.
Thanks for the explanation. I just realized where my confusion lies: I was thinking this enum existed and these strings were serialized currently, when in fact the 7.6 and before request is serialized with boolean flags.
| DISCOVERY("discovery"), | ||
| INGEST("ingest"), | ||
| ADAPTIVE_SELECTION("adaptiveSelection"); | ||
| ADAPTIVE_SELECTION("adaptive_selection"); |
There was a problem hiding this comment.
Thanks for the explanation. I just realized where my confusion lies: I was thinking this enum existed and these strings were serialized currently, when in fact the 7.6 and before request is serialized with boolean flags.
4 participants
This is a small bit of #53637 that will save us some headaches if it sneaks into 7.7 before we cut an official release. It just changes the value of a string constant that is being introduced in 7.7.
As described here, this is not a change to the user-facing value for the adaptive selection metric. It simply changes the internal token so that it matches the adaptive selection metric.