Skip to content

Upgrade to Jackson 2.10.3 #53523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Mar 14, 2020
Merged

Upgrade to Jackson 2.10.3 #53523

merged 19 commits into from
Mar 14, 2020

Conversation

@jasontedor
Copy link
Member

@jasontedor jasontedor commented Mar 12, 2020 •
edited
Loading

This commit upgrades our Jackson dependency to 2.10.3. We intentionally exclude ingest-geoip, we will handle that one separately.

Relates #27032
Relates #45225

@jasontedor
Upgrade to Jackson 2.10.3
ea366bd 
This commit upgrades our Jackson dependency to 2.10.3. We intentionally
exclude ingest-geoip, we will handle that one separately.
@jasontedor jasontedor added :Core/Infra/Core Core issues without another label >upgrade v8.0.0 v7.7.0 labels Mar 12, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 12, 2020

Pinging @elastic/es-core-infra (:Core/Infra/Core)

@jasontedor jasontedor mentioned this pull request Mar 12, 2020
Merged
@jasontedor jasontedor requested a review from dakrone March 12, 2020 23:09
dakrone
dakrone approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but it appears that the failure is actually valid and changes now that Jackson returns Float instead of Double, is this liable to cause us any actual problems down the road? Is this breaking for HLRC users?

rjernst
rjernst reviewed Mar 12, 2020
View reviewed changes
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can upgrading jackson separately in ingest-geoip work when jackson is a core dependency? We do not package core dependencies in modules/plugins, so jackson-core does not existing within the ingest-geoip module (but jackson-databind does).

@jasontedor
Copy link
Member Author

jasontedor commented Mar 13, 2020

@rjernst Good catch. Let me see about updating ingest-geoip in this pull request then.

@jasontedor jasontedor merged commit 7bc75f4 into elastic:master Mar 14, 2020
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Mar 14, 2020
@jasontedor
Upgrade to Jackson 2.10.3 and GeoIP2 to 2.13.1 (elastic#53523)
db6efd9 
This commit upgrades our Jackson dependency to 2.10.3 and our GeoIP2
dependency to 2.13.1.
@jasontedor jasontedor mentioned this pull request Mar 14, 2020
Merged
jasontedor added a commit that referenced this pull request Mar 14, 2020
@jasontedor
Upgrade to Jackson 2.10.3 and GeoIP2 to 2.13.1 (#53576)
b7dbade 
This commit upgrades our Jackson dependency to 2.10.3 and our GeoIP2
dependency to 2.13.1.

Relates #53523
@jasontedor jasontedor deleted the jackson-2.10.3-question-mark branch March 14, 2020 17:30
mark-vieira added a commit that referenced this pull request Mar 16, 2020
@mark-vieira
Revert "Upgrade to Jackson 2.10.3 and GeoIP2 to 2.13.1 (#53523)"
060b4ee 
This reverts commit 7bc75f4

Signed-off-by: Mark Vieira <[email protected]>
This was referenced Mar 16, 2020
Closed
Closed
Closed
Closed
@mark-vieira
Copy link
Contributor

mark-vieira commented Mar 16, 2020

This was reverted after it started causing a number of test failures in CI. See the linked issues ☝️

rjernst added a commit that referenced this pull request Mar 16, 2020
@rjernst
Revert "Revert "Upgrade to Jackson 2.10.3 and GeoIP2 to 2.13.1 (#53523)…
f453295 
…""

This reverts commit 060b4ee.
rjernst added a commit that referenced this pull request Mar 16, 2020
@rjernst
Use float directly for SMILE when serializing random object
6f2446a 
In Jackson 2.9 SMILE handles floats directly instead of expecting
doubles.

relates #53523
closes #53626
@rjernst rjernst mentioned this pull request Mar 17, 2020
Merged
rjernst added a commit that referenced this pull request Mar 17, 2020
@rjernst @nik9000
@dakrone @jakelandis
Upgrade jackson to 2.10.3 and GeoIP to 2.13.1 (#53642)
d63cda1 
Re-applies the change from #53523 along with test fixes.

closes #53626
closes #53624
closes #53622
closes #53625

Co-authored-by: Nik Everett <[email protected]>
Co-authored-by: Lee Hinman <[email protected]>
Co-authored-by: Jake Landis <[email protected]>
rjernst added a commit that referenced this pull request Mar 17, 2020
@rjernst @nik9000
@dakrone @jakelandis
Upgrade jackson to 2.10.3 and GeoIP to 2.13.1 (#53642)
5c472fc 
Re-applies the change from #53523 along with test fixes.

closes #53626
closes #53624
closes #53622
closes #53625

Co-authored-by: Nik Everett <[email protected]>
Co-authored-by: Lee Hinman <[email protected]>
Co-authored-by: Jake Landis <[email protected]>
@codebrain codebrain mentioned this pull request Apr 1, 2020
Closed
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjernst rjernst rjernst left review comments

@dakrone dakrone dakrone approved these changes

Assignees

No one assigned

Labels

:Core/Infra/Core Core issues without another label >upgrade v7.7.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jasontedor @elasticmachine @mark-vieira @dakrone @rjernst @jakelandis