Skip to content

Use optionalVLong #53149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2020
Merged

Use optionalVLong #53149

merged 1 commit into from
Mar 9, 2020

Conversation

@tvernum
Copy link
Contributor

@tvernum tvernum commented Mar 5, 2020

Updates SamlServiceProviderDocument to use the new
read/writeOptionalVLong methods from #53145

@tvernum
Use optionalVLong
570dfa5 
Updates SamlServiceProviderDocument to use the new
read/writeOptionalVLong methods from elastic#53145
@tvernum tvernum added >non-issue :Security/Security Security issues without another label labels Mar 5, 2020
@tvernum tvernum requested a review from jkakavas March 5, 2020 05:13
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 5, 2020

Pinging @elastic/es-security (:Security/Security)

jkakavas
jkakavas approved these changes Mar 8, 2020
View reviewed changes
Copy link
Contributor

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvernum tvernum merged commit 498bb7f into elastic:feature-internal-idp Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkakavas jkakavas jkakavas approved these changes

Assignees

No one assigned

Labels

>non-issue :Security/Security Security issues without another label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tvernum @elasticmachine @jkakavas