Add read/writeOptionalVLong to StreamInput/Output #53145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spirit of StreamInput/StreamOutput is that common I/O patterns should be handled by these classes so that the persistence methods in application classes can be kept short, which facilitates easy visual comparison between read and write methods, and reduces risks of having serialization issues due to mismatched implementations. To this end, this change adds readOptionalVLong and writeOptionalVLong methods to these classes as we have started to build up cases where that conditional/null logic has been implemented directly in the read & write methods.
tvernum
added
>non-issue
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
Contributor
Author
|
Relates: #52936 (comment) |
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Mar 5, 2020
Updates SamlServiceProviderDocument to use the new read/writeOptionalVLong methods from elastic#53145
Merged
tvernum
added a commit
that referenced
this pull request
Mar 9, 2020
Updates SamlServiceProviderDocument to use the new read/writeOptionalVLong methods from #53145
dakrone
pushed a commit
to dakrone/elasticsearch
that referenced
this pull request
Mar 12, 2020
The spirit of StreamInput/StreamOutput is that common I/O patterns should be handled by these classes so that the persistence methods in application classes can be kept short, which facilitates easy visual comparison between read and write methods, and reduces risks of having serialization issues due to mismatched implementations. To this end, this change adds readOptionalVLong and writeOptionalVLong methods to these classes as we have started to build up cases where that conditional/null logic has been implemented directly in the read & write methods.
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spirit of StreamInput/StreamOutput is that common I/O patterns should
be handled by these classes so that the persistence methods in
application classes can be kept short, which facilitates easy visual
comparison between read and write methods, and reduces risks of having
serialization issues due to mismatched implementations.
To this end, this change adds readOptionalVLong and writeOptionalVLong
methods to these classes as we have started to build up cases where
that conditional/null logic has been implemented directly in the read &
write methods.