Skip to content

[TEST] Only test US locale in day/month order test in FIPS JVM #45141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2019
Merged

[TEST] Only test US locale in day/month order test in FIPS JVM #45141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .../test/java/org/elasticsearch/xpack/ml/filestructurefinder/TimestampFormatFinderTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,13 @@ public void testGuessIsDayFirstFromLocale() {
TimestampFormatFinder timestampFormatFinder = new TimestampFormatFinder(explanation, true, true, true, NOOP_TIMEOUT_CHECKER);

// Locale fallback is the only way to decide

// The US locale should work for both FIPS and non-FIPS
assertFalse(timestampFormatFinder.guessIsDayFirstFromLocale(Locale.US));

// Non-US locales may not work correctly in a FIPS JVM - see https://github.com/elastic/elasticsearch/issues/45140
assumeFalse("Locales not reliable in FIPS JVM", inFipsJvm());

assertTrue(timestampFormatFinder.guessIsDayFirstFromLocale(Locale.UK));
assertTrue(timestampFormatFinder.guessIsDayFirstFromLocale(Locale.FRANCE));
assertFalse(timestampFormatFinder.guessIsDayFirstFromLocale(Locale.JAPAN));
Expand Down