[TEST] Only test US locale in day/month order test in FIPS JVM #45141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the FIPS JVM the JVM default locale seems to leak into places where it should be overridden. This change skips assertions in TimestampFormatFinderTests.testGuessIsDayFirstFromLocale that may be impacted. Fixes elastic#45140
droberts195
added
>test
Collaborator
|
Pinging @elastic/ml-core |
Author
|
This doesn't seem to be a problem in the 6.8 branch. I am not sure why. /cc @jkakavas |
droberts195
pushed a commit
that referenced
this pull request
Aug 2, 2019
In the FIPS JVM the JVM default locale seems to leak into places where it should be overridden. This change skips assertions in TimestampFormatFinderTests.testGuessIsDayFirstFromLocale that may be impacted. Fixes #45140
droberts195
pushed a commit
that referenced
this pull request
Aug 2, 2019
In the FIPS JVM the JVM default locale seems to leak into places where it should be overridden. This change skips assertions in TimestampFormatFinderTests.testGuessIsDayFirstFromLocale that may be impacted. Fixes #45140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the FIPS JVM the JVM default locale seems to leak into places
where it should be overridden. This change skips assertions
in TimestampFormatFinderTests.testGuessIsDayFirstFromLocale
that may be impacted.
Fixes #45140