[ML][Data Frame] add node attr to GET _stats #43842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core |
Member
|
retest this please |
davidkyle
approved these changes
Jul 2, 2019
Member
davidkyle
left a comment
davidkyle
left a comment
There was a problem hiding this comment.
LGTM. left some minor comments
| .supportsUnknownFields(true) | ||
| .randomFieldsExcludeFilter(field -> field.equals("current_position")) | ||
| .randomFieldsExcludeFilter(field -> field.equals("current_position") || | ||
| field.equals("node") || |
Member
There was a problem hiding this comment.
Could be simplified to field.startsWith("node") but shouldn't it just be the map node.attributes that is ignored.
| @Override | ||
| protected Predicate<String> getRandomFieldsExcludeFilter() { | ||
| return field -> field.equals("state.current_position"); | ||
| return field -> field.equals("state.current_position") || field.equals("state.node") || field.equals("state.node.attributes"); |
| node.getEphemeralId(), | ||
| node.getAddress().toString(), | ||
| // TODO add data_frame attributes when/if they are added | ||
| Collections.emptyMap()); |
Member
There was a problem hiding this comment.
Maybe make attributes nullable so it is not written as an empty object attributes: {} in toXContent
|
|
||
| @Override | ||
| protected Predicate<String> getRandomFieldsExcludeFilter() { | ||
| return field -> !field.isEmpty(); |
Member
There was a problem hiding this comment.
If another nested object besides the attribute map was added to NodeAttributes it would be excluded here.
| private static void setNodeAttributes(DataFrameTransformStateAndStats dataFrameTransformStateAndStats, | ||
| PersistentTasksCustomMetaData persistentTasksCustomMetaData, | ||
| ClusterState state) { | ||
| var pTask = persistentTasksCustomMetaData.getTask(dataFrameTransformStateAndStats.getTransformId()); |
Member
Author
|
@elasticmachine update branch |
Member
Author
|
jenkins retest this please |
Member
Author
|
run elasticsearch-ci/2 |
Member
Author
|
run elasticsearch-ci/packaging-sample |
1 similar comment
Member
Author
|
run elasticsearch-ci/packaging-sample |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Jul 2, 2019
* [ML][Data Frame] add node attr to GET _stats * addressing testing issues with node.attributes
benwtrent
added a commit
that referenced
this pull request
Jul 3, 2019
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds node information to the
_statscall. I made thenodefield part of thestatesub-object. This made the most sense to me asstatealso contains the task state information, and the reason for its current state.closes #43743