[ML] making test more determinate #40374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>test
Collaborator
|
Pinging @elastic/ml-core |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Mar 22, 2019
* [ML] making test more determinate * unmuting test
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 22, 2019
* elastic/master: [DOCS] Adds notable highlights tags (elastic#40330) [ML] making test more determinate (elastic#40374) [ML] adds support for non-numeric mapped types (elastic#40220) Move outbound message handling to OutboundHandler (elastic#40336) Add implicit this for class binding in Painless (elastic#40285) Muting test testExtractIndexCheckpointsInconsistentGlobalCheckpoints (elastic#40371) DOC: polish client docs Fix building bwc versions (elastic#40361)
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 22, 2019
…-stop-time * elastic/master: [DOCS] Adds notable highlights tags (elastic#40330) [ML] making test more determinate (elastic#40374) [ML] adds support for non-numeric mapped types (elastic#40220) Move outbound message handling to OutboundHandler (elastic#40336) Add implicit this for class binding in Painless (elastic#40285)
benwtrent
added a commit
that referenced
this pull request
Mar 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, there was the semi-rare scenario where the
inconsistentReplicawould actually be the primary shard, and not cause a failure. In this change, I force theinconsistentReplicato only be a shard replica and never the primary.closes #40368