Move outbound message handling to OutboundHandler #40336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-Brooks
added
>non-issue
:Distributed Coordination/Network
Collaborator
|
Pinging @elastic/es-distributed |
Contributor
|
Jenkins run elasticsearch-ci/packaging-sample |
| import java.util.List; | ||
| import java.util.concurrent.CopyOnWriteArrayList; | ||
|
|
||
| final class DelegatingTransportMessageListener implements TransportMessageListener { |
Contributor
There was a problem hiding this comment.
This is just org.elasticsearch.transport.TransportService.DelegatingTransportMessageListener an we should delete it from TransportService then?
Contributor
Author
There was a problem hiding this comment.
I deleted the stand alone class. It was from an unrelated change.
original-brownbear
approved these changes
Mar 22, 2019
Contributor
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
thanks @tbrooks8 LGTM
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 22, 2019
* elastic/master: [DOCS] Adds notable highlights tags (elastic#40330) [ML] making test more determinate (elastic#40374) [ML] adds support for non-numeric mapped types (elastic#40220) Move outbound message handling to OutboundHandler (elastic#40336) Add implicit this for class binding in Painless (elastic#40285) Muting test testExtractIndexCheckpointsInconsistentGlobalCheckpoints (elastic#40371) DOC: polish client docs Fix building bwc versions (elastic#40361)
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 22, 2019
…-stop-time * elastic/master: [DOCS] Adds notable highlights tags (elastic#40330) [ML] making test more determinate (elastic#40374) [ML] adds support for non-numeric mapped types (elastic#40220) Move outbound message handling to OutboundHandler (elastic#40336) Add implicit this for class binding in Painless (elastic#40285)
Tim-Brooks
added a commit
that referenced
this pull request
Mar 27, 2019
Currently there are some components of message serializer and sending that still occur in TcpTransport. This commit makes it possible to send a message without the TcpTransport by moving all of the remaining application logic to the OutboundHandler. Additionally, it adds unit tests to ensure that this logic works as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are some components of message serializer and sending
that still occur in
TcpTransport. This commit makes it possible tosend a message without the
TcpTransportby moving all of the remainingapplication logic to the
OutboundHandler. Additionally, it adds unittests to ensure that this logic works as expected.