Reindex from Remote allow date math #40303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, reindexing from remote using date math in the source index name did not work if the math contained / or ,. A workaround was to then URL escape the index name in the request. With this change, we now support any index name in the remote request that the remote source supports, doing the URL escape when sending the request.
henningandersen
added
>feature
:Distributed Indexing/CRUD
Collaborator
|
Pinging @elastic/es-distributed |
Contributor
Author
|
@elasticmachine test this please |
…ote_allow_data_math
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample |
henningandersen
added a commit
that referenced
this pull request
Apr 1, 2019
Previously, reindexing from remote using date math in the source index name did not work if the math contained / or ,. A workaround was to then URL escape the index name in the request. With this change, we now support any index name in the remote request that the remote source supports, doing the URL escape when sending the request. Related to #23533
Contributor
Author
|
Thanks @tbrooks8 |
This was referenced Apr 9, 2019
henningandersen
added a commit
that referenced
this pull request
Apr 16, 2019
Removed the leniency when encoding remote reindex search requests that was introduced in 7.x. All index-names are now encoded before being sent to the remote host. Follow-up to #40303
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Previously, reindexing from remote using date math in the source index name did not work if the math contained / or ,. A workaround was to then URL escape the index name in the request. With this change, we now support any index name in the remote request that the remote source supports, doing the URL escape when sending the request. Related to elastic#23533
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Removed the leniency when encoding remote reindex search requests that was introduced in 7.x. All index-names are now encoded before being sent to the remote host. Follow-up to elastic#40303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, reindexing from remote using date math in the source index
name did not work if the math contained / or ,. A workaround was to
then URL escape the index name in the request.
With this change, we now support any index name in the remote request
that the remote source supports, doing the URL escape when sending the
request.
The change still allows escaped requests to allow rolling upgrades. This will be removed in an 8.0 only follow-up.
Related to #23533