Skip to content

Conversation

@henningandersen
Copy link
Contributor

Removed the leniency when encoding remote reindex search requests that
was introduced in 7.x. All index-names are now encoded before being sent
to the remote host.

Follow-up to #40303

Removed the leniency when encoding remote reindex search requests that
was introduced in 7.x. All index-names are now encoded before being sent
to the remote host.
@henningandersen henningandersen added :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >breaking v8.0.0 labels Apr 9, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

[[breaking_80_reindex_changes]]
=== Reindex changes

Reindex from remote would previously allow URL encoded index-names and not re-encode them when generating the search
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a drive-by comment only, but we like to wrap our docs at eighty columns. 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jasontedor , fixed in 67dd80f.

Line width is to be 80 chars.
@henningandersen henningandersen added :Distributed Indexing/Reindex Issues relating to reindex that are not caused by issues further down and removed :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. labels Apr 12, 2019
Copy link
Contributor

@Tim-Brooks Tim-Brooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@henningandersen
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/packaging-sample

@henningandersen henningandersen merged commit 8dbdd06 into elastic:master Apr 16, 2019
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
Removed the leniency when encoding remote reindex search requests that
was introduced in 7.x. All index-names are now encoded before being sent
to the remote host.

Follow-up to elastic#40303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>breaking :Distributed Indexing/Reindex Issues relating to reindex that are not caused by issues further down >feature v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants