-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Reindex from Remote encoding #41007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reindex from Remote encoding #41007
Conversation
Removed the leniency when encoding remote reindex search requests that was introduced in 7.x. All index-names are now encoded before being sent to the remote host.
|
Pinging @elastic/es-distributed |
| [[breaking_80_reindex_changes]] | ||
| === Reindex changes | ||
|
|
||
| Reindex from remote would previously allow URL encoded index-names and not re-encode them when generating the search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a drive-by comment only, but we like to wrap our docs at eighty columns. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jasontedor , fixed in 67dd80f.
Line width is to be 80 chars.
Tim-Brooks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ote_allow_data_math_followup
|
@elasticmachine run elasticsearch-ci/packaging-sample |
Removed the leniency when encoding remote reindex search requests that was introduced in 7.x. All index-names are now encoded before being sent to the remote host. Follow-up to elastic#40303
Removed the leniency when encoding remote reindex search requests that
was introduced in 7.x. All index-names are now encoded before being sent
to the remote host.
Follow-up to #40303