Remove transport name from tcp channel #40074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we maintain a transport name ("mock-nio", "nio", "netty")
that is passed to a `TcpTransportChannel` when a request is received.
The value of this name is to associate with the task when we register a
task with the task manager. However, it is only possible to run ES with
one transport, so having an implementation specific name is unnecessary.
This commit removes the name and replaces it with the generic
"tcp-transport".
Tim-Brooks
added
>non-issue
:Distributed Coordination/Network
Collaborator
|
Pinging @elastic/es-distributed |
Contributor
Author
|
Currently our task
The last one will be replaced by |
Tim-Brooks
changed the title
s1monw
approved these changes
Mar 15, 2019
Contributor
s1monw
left a comment
s1monw
left a comment
There was a problem hiding this comment.
+1 to rename to transport
Tim-Brooks
added a commit
that referenced
this pull request
Mar 15, 2019
Currently, we maintain a transport name ("mock-nio", "nio", "netty")
that is passed to a `TcpTransportChannel` when a request is received.
The value of this name is to associate with the task when we register a
task with the task manager. However, it is only possible to run ES with
one transport, so having an implementation specific name is unnecessary.
This commit removes the name and replaces it with the generic
"transport".
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 16, 2019
…te-size-hard-failure * elastic/master: use shell with JAVA_HOME for starting archive (elastic#40118) Remove Migration Upgrade and Assistance APIs (elastic#40075) Revert "Fix IndexSearcherWrapper visibility (elastic#39071)" Remove transport name from tcp channel (elastic#40074) Document the limitation around field aliases and percolator. (elastic#40073) SQL: Refactor Literals serialization method (elastic#40058)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we maintain a transport name ("mock-nio", "nio", "netty")
that is passed to a
TcpTransportChannelwhen a request is received.The value of this name is to associate with the task when we register a
task with the task manager. However, it is only possible to run ES with
one transport, so having an implementation specific name is unnecessary.
This commit removes the name and replaces it with the generic
"transport".