SQL: Refactor Literals serialization method #40058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since other classes besides intervals can be serialized as part of the Cursor, the getNamedWritables method should be moved from Intervals to a more generic class Literals. Relates to elastic#39973
Collaborator
|
Pinging @elastic/es-search |
astefan
reviewed
Mar 14, 2019
x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/expression/literal/Literals.java
Show resolved
Hide resolved
imotov
added a commit
that referenced
this pull request
Mar 15, 2019
Since other classes besides intervals can be serialized as part of the Cursor, the getNamedWritables method should be moved from Intervals to a more generic class Literals. Relates to #39973
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 16, 2019
…te-size-hard-failure * elastic/master: use shell with JAVA_HOME for starting archive (elastic#40118) Remove Migration Upgrade and Assistance APIs (elastic#40075) Revert "Fix IndexSearcherWrapper visibility (elastic#39071)" Remove transport name from tcp channel (elastic#40074) Document the limitation around field aliases and percolator. (elastic#40073) SQL: Refactor Literals serialization method (elastic#40058)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since other classes besides intervals can be serialized as part of
the Cursor, the getNamedWritables method should be moved from Intervals
to a more generic class Literals.
Relates to #39973