Reenable MonitoringIT.testMonitoringService #38332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tlrx merged 4 commits into elastic:master from tlrx:reenable-monitoring-it-service

Feb 11, 2019

Member

tlrx commented Feb 4, 2019

This pull request reenables the test MonitoringIT.testMonitoringService and gives it a bit more time to start. This is curious that the test testMonitoringBulk passes and not this one, so I'm opening this pull request and I'll give it many CI builds to see if it fails a lot or not.

Closes #29880


          Reenable MonitoringIT.testMonitoringService

9cea058

Closes elastic#29880

tlrx added >test v7.0.0 :Data Management/Monitoring v6.7.0 labels

Collaborator

elasticmachine commented Feb 4, 2019

Pinging @elastic/es-core-features

Member Author

tlrx commented Feb 4, 2019

Test is green, let's run it again: @elasticmachine run elasticsearch-ci/2

2 similar comments

Member Author

tlrx commented Feb 4, 2019

Test is green, let's run it again: @elasticmachine run elasticsearch-ci/2

Member Author

tlrx commented Feb 5, 2019

Test is green, let's run it again: @elasticmachine run elasticsearch-ci/2

Member Author

tlrx commented Feb 5, 2019

Test is red but this is unrelated to this change, let's run it again: @elasticmachine run elasticsearch-ci/2

1 similar comment

Member Author

tlrx commented Feb 5, 2019

Test is red but this is unrelated to this change, let's run it again: @elasticmachine run elasticsearch-ci/2

Member Author

tlrx commented Feb 5, 2019

Test is green, let's run it again: @elasticmachine run elasticsearch-ci/2

1 similar comment

Member Author

tlrx commented Feb 5, 2019

Test is green, let's run it again: @elasticmachine run elasticsearch-ci/2


          Merge branch 'master' into reenable-monitoring-it-service

59f3a5d

Member Author

tlrx commented Feb 6, 2019

Given the facts that this pull request got many successful builds and that the other test in the same class does not fail, I think we can reenable the muted test and see how it goes.

Can anyone from the @elastic/es-core-features team review this please?

jasontedor added v8.0.0 and removed v7.0.0 labels

jakelandis reviewed

View reviewed changes

...in/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/integration/MonitoringIT.java

    
                      assertThat(clusterState.remove("state_uuid"), notNullValue());

                      assertThat(clusterState.remove("cluster_uuid"), notNullValue());

                      assertThat(clusterState.remove("master_node"), notNullValue());

                      assertThat(clusterState.remove("nodes"), notNullValue());

Contributor

jakelandis Feb 6, 2019

Curious to why we are removing these assertions ?

Member Author

tlrx Feb 6, 2019

I think it's been added for Zen 2 but removed afterwards, but not noticed since the test was muted.

jakelandis approved these changes

View reviewed changes

Contributor

jakelandis left a comment

LGTM

danielmitterdorfer added v7.2.0 and removed v6.7.0 labels


          Merge branch 'master' into reenable-monitoring-it-service

1b3a5ba

Member Author

tlrx commented Feb 8, 2019

@elasticmachine run elasticsearch-ci/1


          Merge branch 'master' into reenable-monitoring-it-service

3b5f79f

tlrx merged commit 1446abd into elastic:master

tlrx deleted the reenable-monitoring-it-service branch

February 11, 2019 10:37

Member Author

tlrx commented Feb 11, 2019

Thanks @jakelandis ! I merged this pull request and I'm going to let it run on CI/master for a few days before backporting the change to other branches.

tlrx added the backport pending label

jpountz removed the backport pending label

jpountz removed the v7.2.0 label

Contributor

jpountz commented Mar 5, 2019

Removing the v7.1.0 and backport pending labels after discussing with @tlrx.

jakelandis added v8.0.0-alpha1 and removed v8.0.0 labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/Monitoring >test v8.0.0-alpha1