Skip to content

Commit 1446abd

Browse files
authored
Reenable MonitoringIT.testMonitoringService (#38332)
Closes #29880
1 parent 4766fa0 commit 1446abd

File tree

1 file changed

+3
-6
lines changed
  • x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/integration

1 file changed

+3
-6
lines changed

x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/integration/MonitoringIT.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@
6464
import java.util.List;
6565
import java.util.Map;
6666
import java.util.Optional;
67+
import java.util.concurrent.TimeUnit;
6768
import java.util.concurrent.atomic.AtomicReference;
6869
import java.util.stream.Collectors;
6970

@@ -189,7 +190,6 @@ public void testMonitoringBulk() throws Exception {
189190
* This test waits for the monitoring service to collect monitoring documents and then checks that all expected documents
190191
* have been indexed with the expected information.
191192
*/
192-
@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/29880")
193193
public void testMonitoringService() throws Exception {
194194
final boolean createAPMIndex = randomBoolean();
195195
final String indexName = createAPMIndex ? "apm-2017.11.06" : "books";
@@ -374,9 +374,6 @@ private void assertClusterStatsMonitoringDoc(final Map<String, Object> document,
374374
assertThat(clusterState.remove("cluster_uuid"), notNullValue());
375375
assertThat(clusterState.remove("master_node"), notNullValue());
376376
assertThat(clusterState.remove("nodes"), notNullValue());
377-
assertThat(clusterState.remove("term"), notNullValue());
378-
assertThat(clusterState.remove("last_committed_config"), notNullValue());
379-
assertThat(clusterState.remove("last_accepted_config"), notNullValue());
380377
assertThat(clusterState.keySet(), empty());
381378

382379
final Map<String, Object> clusterSettings = (Map<String, Object>) source.get("cluster_settings");
@@ -612,7 +609,7 @@ public void enableMonitoring() throws Exception {
612609
.setSize(0)
613610
.get().getHits().getTotalHits().value,
614611
greaterThan(0L));
615-
});
612+
}, 30L, TimeUnit.SECONDS);
616613
}
617614

618615
/**
@@ -649,7 +646,7 @@ public void disableMonitoring() throws Exception {
649646
} catch (Exception e) {
650647
throw new ElasticsearchException("Failed to wait for monitoring exporters to stop:", e);
651648
}
652-
});
649+
}, 30L, TimeUnit.SECONDS);
653650
}
654651

655652
private boolean getMonitoringUsageExportersDefined() throws Exception {

0 commit comments

Comments
 (0)