Skip to content

Conversation

@dr0i
Copy link
Contributor

@dr0i dr0i commented Jan 24, 2019

Resolves #37658.

@colings86 colings86 added the :Search Foundations/Mapping Index mappings, including merging and defining field types label Jan 24, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@mayya-sharipova
Copy link
Contributor

@elasticmachine test this please

1 similar comment
@mayya-sharipova
Copy link
Contributor

@elasticmachine test this please

@mayya-sharipova
Copy link
Contributor

@elasticmachine test this please

@dr0i
Copy link
Contributor Author

dr0i commented Jan 29, 2019

@mayya-sharipova as you see I had some problems with testing. I added two commits and you started the integration test again, thanks !

If I locally test everything with ./gradlew check, it fails because of TransportException and such. The automatic build tests also fail with these errors.
But I don't think this is because of my changes (logging an ID).
So I test only the package which tests the affected code (EDIT: after rebasing my branch to be up-to-date):
./gradlew --debug cleanTest "-Dtests.class=org.elasticsearch.index.mapper.*"
This results in BUILD SUCCESSFUL.
I also had a quick look at others' PR and there it also seems often the case that the whole testing don't work. Can you help me get things straight?

@dr0i
Copy link
Contributor Author

dr0i commented Jan 29, 2019

Uh - ./gradlew check works now - no more TransportExceptions. Hopefully these are also gone when the automatic tests by elasticmachine are executed.
(What I changed: 1. rebased to newest master ; 2. used an other machine). Maybe the cause was e.g. #37893 et al, where tests randomly failing and are mow muted in the tip of the newest master.

@mayya-sharipova
Copy link
Contributor

@elasticmachine test this please

@mayya-sharipova
Copy link
Contributor

@elasticmachine test this please

@mayya-sharipova
Copy link
Contributor

@dr0i Thank you for your PR, it is approved! I will try to monitor the CI build, and once all the tests are passed, I will merge your PR to the upstream master.

@mayya-sharipova mayya-sharipova merged commit a3d9ba3 into elastic:master Jan 31, 2019
@dr0i
Copy link
Contributor Author

dr0i commented Feb 1, 2019

@mayya-sharipova great, thx !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types v6.7.0 v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants