Build: Make assemble a noop in bwc projects #37245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the assemble tasks in the bwc projects noops by setting the dependsOn directly. While we can not remove things from dependsOn, we can still completely override the dependencies. closes elastic#33581
rjernst
added
:Delivery/Build
Collaborator
|
Pinging @elastic/es-core-infra |
alpar-t
reviewed
Jan 9, 2019
| } | ||
| } | ||
| // make sure no dependencies were added to assemble; we want it to be a no-op | ||
| assemble.dependsOn = [] |
Contributor
There was a problem hiding this comment.
Will this work when the bwc version are actually needed ?
I was under the impression that builtBy actually work by adding dependencies which we could be removing here. Maybe it adds them to build also and that's sufficient ?
Member
Author
There was a problem hiding this comment.
It will (I tested it, and the passing CI shows this works too since it runs eg qa/full-cluster-restart which builds bwc). The dependent project triggers the builtBy task, not assemble.
alpar-t
approved these changes
Jan 9, 2019
rjernst
added a commit
that referenced
this pull request
Jan 9, 2019
This commit makes the assemble tasks in the bwc projects noops by setting the dependsOn directly. While we can not remove things from dependsOn, we can still completely override the dependencies. closes #33581
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the assemble tasks in the bwc projects noops by
setting the dependsOn directly. While we can not remove things from
dependsOn, we can still completely override the dependencies.
closes #33581