Gradle assemble task builds BWC versions too

[DaveCTurner]

Today, in both 6.x and master, executing ./gradlew assemble will run BWC-related tasks such as :distribution:bwc:next-{bugfix,minor}-snapshot:buildBwcVersion, which appears to be unnecessary for the ultimate goal of the assemble task.

[elasticmachine]

Pinging @elastic/es-core-infra

[rjernst]

This was recently addressed by #33372. @DaveCTurner are you sure this is still an issue?

[DaveCTurner]

Apologies, by "Today" I clearly meant "a week ago", and the handful of PR builds I looked at had not picked up #33372. Sorry for the noise.

[original-brownbear]

This problem seems to be back. With current master (e778aba) I again see the Bwc versions being built for ./gradlew assemble.

[original-brownbear]

@atorok can you take another look?

[alpar-t]

@original-brownbear I can't reproduce. was ./gradlew assemble your entire command line ?

[original-brownbear]

@atorok I tracked this down (sorta).

If I run the build from my normal zsh shell ./gradlew assemble no BwC archives are built.
If I run the following script (I have ES checked out in ./build/elasticsearch relative to the script):

#!/usr/bin/env bash
cd ./build/elasticsearch && ./gradlew clean assemble

it builds the Bwc archives ...
It could be some difference in my bash and zsh environments or so?
Regardless, it's kinda weird this happens :D If you can't reproduce it though, I can take a look. No need to waste your time, this is pretty fringe obviously :)

[alpar-t]

./gradlew clean assemble will build the bwc versions. We only short circuit it if assemble is the only task on the command line. The reason is that it's too complex to reason about what other tasks might do and if they require bwc versions or not.

[original-brownbear]

@atorok

🤦‍♂️ my bad => sorry for the noise :)