Skip to content

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented Dec 31, 2018

substract/subtract appears to be an API which should get a distinct review. (Note: similar spelling changes that aren't technically part of the API are included as well.)
split from #37035

@jsoref jsoref force-pushed the spelling-api-subtract branch from 6c03c20 to 4438ac3 Compare December 31, 2018 17:54
@javanna javanna added the :Analytics/SQL SQL querying label Jan 2, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@javanna
Copy link
Member

javanna commented Jan 2, 2019

test this please

Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javanna
Copy link
Member

javanna commented Jan 2, 2019

thanks a lot @jsoref !

@jsoref jsoref deleted the spelling-api-subtract branch January 2, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants