Spelling #37035

jsoref · 2018-12-31T00:08:59Z

Generated by https://github.com/jsoref/spelling f; to maintain your repo, please consider fchurn

Have you signed the contributor license agreement?
Have you followed the contributor guidelines?
- I haven't opened an issue. I can at some point. I don't expect it to be particularly helpful. It took a couple of weekends to put together this PR...
- These were rebased to master (because there were conflicts). This will fall behind, fchurn can be used to deal w/ rebasing the last mile if people are interested.
- These aren't squashed. There are a number of changes that need to be considered, and it's much easier for me if people review the delta and complain about word families. I'll drop individual families as I receive objections. Once objections are handled, squashing is trivial.
If submitting code, have you built your formula locally prior to submission with gradle check?
If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
If submitting code, have you checked that your submission is for an OS that we support?

jsoref · 2018-12-31T00:21:33Z

client/rest-high-level/src/main/java/org/elasticsearch/client/RethrottleRequest.java

I'm hoping this is a debugging object

jsoref · 2018-12-31T00:23:13Z

docs/java-rest/high-level/getting-started.asciidoc

I think this is just a section name, but it's possible things link to it

This should be high, rather than height

jsoref · 2018-12-31T00:23:29Z

docs/java-rest/high-level/migration/get-assistance.asciidoc

I think this is just a section name, but it's possible things link to it

jsoref · 2018-12-31T00:23:38Z

docs/java-rest/high-level/migration/upgrade.asciidoc

I think this is just a section name, but it's possible things link to it

jsoref · 2018-12-31T00:23:45Z

docs/java-rest/high-level/migration/upgrade.asciidoc

I think this is just a section name, but it's possible things link to it

jsoref · 2018-12-31T00:46:18Z

x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/plan/QueryPlan.java

This is probably an api change

x-pack/plugin/watcher/src/main/java/org/elasticsearch/xpack/watcher/Watcher.java

...rg/elasticsearch/xpack/watcher/notification/email/attachment/HttpEmailAttachementParser.java

jsoref · 2018-12-31T00:48:30Z

...ugin/watcher/src/test/java/org/elasticsearch/xpack/watcher/WatcherLifeCycleServiceTests.java

Really not sure about this

...asticsearch/xpack/watcher/notification/email/attachment/HttpEmailAttachementParserTests.java

tvernum

I tried to do a first pass on this, but really I think it is too big for us to ever actually get this merged.
I think I got about 2/3 of the way through it, and that was just glancing at each change looking for obvious problems.

Just doing to proper review of each change will take a couple of hours, and that's not accounting for looking into the changes that are questionable (many of which you've already highlighted).

By the time we reached a conclusion on all the changes, the code base would have moved so much that the merges would become ugly and someone would have to spend more time sorting that out.

If you want to see this to completion I think we need to get it split into manageable pieces. My recommendations:

Start with anything in the docs because those have real value (and there's probably not many of them).
Skip the ie. -> i.e. and eg. -> e.g. ; Yes it's technically correct, but there's a lot of them and it creates a lot of noise for very minimal value.
Split the API changes (class names, public method names) into separate PRs so that they can get 1 good review and be merged. e.g. one for each of the isCacheable and Interruptible changes.
then let's see what's left over.

tvernum · 2018-12-31T02:58:24Z

docs/java-rest/high-level/getting-started.asciidoc

This should be high, rather than height

tvernum · 2018-12-31T03:02:16Z

docs/reference/mapping/params/similarity.asciidoc

The page it is linking to is https://www.elastic.co/guide/en/elasticsearch/guide/current/pluggable-similarites.html (which has a typo, but we can live with it).

Can you revert this change please?

tvernum · 2018-12-31T03:36:03Z

server/src/main/java/org/elasticsearch/action/support/master/TransportMasterNodeAction.java


    /**
-     * @deprecated new implementors should override {@link #read(StreamInput)} and use the
+     * @deprecated new implementers should override {@link #read(StreamInput)} and use the


Strictly speaking both implementor and implementer are correct usage, so I'm not sure it's worth the churn to change these.

tvernum · 2018-12-31T03:41:37Z

server/src/main/java/org/elasticsearch/common/settings/AbstractScopedSettings.java

+                    throw new IllegalArgumentException("final " + type + " setting [" + key + "], not updatable");
                } else {
-                    throw new IllegalArgumentException(type + " setting [" + key + "], not dynamically updateable");
+                    throw new IllegalArgumentException(type + " setting [" + key + "], not dynamically updatable");


Strictly, both are correct, but our docs seem to prefer updatable, so this is probably a good change.

tvernum · 2018-12-31T03:48:33Z

server/src/test/java/org/elasticsearch/common/settings/SettingTests.java

@@ -277,14 +277,14 @@ public void testDefault() {

        // It gets more complicated when there are two settings objects....
        Settings hasFallback = Settings.builder().put("foo.bar", "o").build();
-        Setting<String> fallsback =
+        Setting<String> fallsBack =


If we're going to change this one, I think it should just be fallback

I normally would have picked fallback, the only reason I didn't was that I was wondering if the code was trying to speak about the action of falling back as opposed to the actual fallback.

I'm quite happy to switch (and will when I get to the code side, I think that'll come after the API bits get split out).

jsoref · 2018-12-31T13:06:37Z

Sure.

javanna · 2018-12-31T14:44:09Z

I agree with @tvernum , these are good changes, but they should be made one step at a time in smaller PRs. I will close this then, looking forward to your upcoming PRs @jsoref !

jsoref · 2018-12-31T16:43:59Z

For reference,
https://github.com/jsoref/elasticsearch/tree/spelling is more or less "what's left" and
https://github.com/jsoref/elasticsearch/tree/spelling-full is more or less the full set of changes (including i.e./e.g. and similarities, but with the correction for high, i.e. roughly the original PR)

jsoref · 2018-12-31T16:44:09Z

I think this is as far as I'm likely to go today.

javanna · 2018-12-31T17:10:06Z

thanks you @jsoref !

jsoref · 2018-12-31T17:58:25Z

For my reference, the elasticsearch build system doesn't like my git metadata... The following works to strip the metadata (by recreating a branch's single commit w/ its single-line commit message):

for a in $(cat); do
git checkout master;
git branch -D X;
git checkout -b X;
git show $a |patch -p1;
git add .;
git commit -m "$(git log --format=%B -n 1 $a|head -1)";
git diff $a..X &&
 git branch -D $a &&
 git checkout -b $a &&
 git branch -D X &&
 git push github $a -f;
done

(yes, one of the two deletes of the X branch will fail, but that's just paranoia)

jsoref added 30 commits December 28, 2018 04:28

spelling: easily

6a22d58

spelling: eligible

6ee7dc2

spelling: emptiness

e09efcd

spelling: empty

cf0e999

spelling: enable

cb2e8cd

spelling: encrypted

14523b1

spelling: enqueued

2098bc9

spelling: enqueuing

c503ccd

spelling: everything

277d181

spelling: everywhere

c61c705

spelling: exception

71a2d1a

spelling: excluding

c5252f2

spelling: executable

55d6768

spelling: execute

be81119

spelling: execution

03f29b8

spelling: executions

dd9845c

spelling: expectation

8b4f1fd

spelling: expected

7c14188

spelling: expander

a84ea15

spelling: expect

89dab44

spelling: explicit

fea7485

spelling: explicitly

4b0afcd

spelling: expression

5aea753

spelling: extract

89ca3a0

spelling: extractor

f9ec9a8

spelling: failure

8f97408

spelling: falls-back

135dcfd

spelling: fallthrough

5f28720

spelling: field

bb6e3cd

spelling: first

5fba568

jsoref commented Dec 31, 2018

View reviewed changes

jsoref added 9 commits December 30, 2018 20:48

spelling: program

752eada

spelling: programmatically

f8bfcf3

spelling: sorted

ab00eb6

spelling: specified

be69cc5

spelling: methodology

33d5c0f

spelling: migration

6c92f5e

spelling: using

3a79382

spelling: values

2aa6af3

spelling: variation

b182637

jsoref force-pushed the spelling branch from ac26520 to 510dc5e Compare December 31, 2018 02:37

tvernum reviewed Dec 31, 2018

View reviewed changes

javanna closed this Dec 31, 2018

jsoref mentioned this pull request May 17, 2020

Use go-git for looking up repository details nektos/act#164

Closed

Spelling #37035

Spelling #37035

Uh oh!

Conversation

jsoref commented Dec 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tvernum left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jsoref commented Dec 31, 2018

Uh oh!

javanna commented Dec 31, 2018

Uh oh!

jsoref commented Dec 31, 2018

Uh oh!

jsoref commented Dec 31, 2018

Uh oh!

javanna commented Dec 31, 2018

Uh oh!

jsoref commented Dec 31, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jsoref commented Dec 31, 2018 •

edited

Loading