SQL: new SQL CLI logo #35261
Merged
SQL: new SQL CLI logo #35261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o sql_elastic_logo
…o sql_elastic_logo
Collaborator
|
Pinging @elastic/es-search-aggs |
Member
|
Cute. |
Contributor
Author
matriv
reviewed
Nov 6, 2018
| try (BufferedReader reader = new BufferedReader(new InputStreamReader(in, StandardCharsets.UTF_8))) { | ||
| String line; | ||
| while ((line = reader.readLine()) != null) { | ||
| if (line.length() > lineLength) { |
Contributor
There was a problem hiding this comment.
You can use Math.max() to avoid the if.
matriv
reviewed
Nov 6, 2018
| boolean isLogoOrException = false; | ||
| while (!isLogoOrException) { | ||
| String line = readLine(); | ||
| isLogoOrException = line.contains("SQL"); |
Contributor
There was a problem hiding this comment.
You can check with "SQL".equals(line.trim()) to avoid the isLogoOrException.
Contributor
|
Left a couple of suggestions. |
costin
approved these changes
Nov 6, 2018
Member
costin
left a comment
costin
left a comment
There was a problem hiding this comment.
LGTM. Next stop, ANSI colors :)
| } | ||
|
|
||
| // print the version centered on the last line | ||
| char[] whitespaces = new char[lineLength / 2 - Version.CURRENT.version.length() / 2]; |
Member
There was a problem hiding this comment.
To minimize rounding errors use (lineLength-Version.CURRENT.version.length())/2. It's also shorter.
astefan
added a commit
that referenced
this pull request
Nov 6, 2018
Added new SQL CLI logo representing the Elastic logo "painted" with "Elastic" words, "SQL" under the logo and version on the last line
matarrese
added a commit
to matarrese/elasticsearch
that referenced
this pull request
Nov 6, 2018
…-agg * master: (528 commits) Register Azure max_retries setting (elastic#35286) add version 6.4.4 [Docs] Add painless context details for bucket_script (elastic#35142) Upgrade jline to 3.8.2 (elastic#35288) SQL: new SQL CLI logo (elastic#35261) Logger: Merge ESLoggerFactory into Loggers (elastic#35146) Docs: Add section about range query for range type (elastic#35222) [ILM] change remove-policy-from-index http method from DELETE to POST (elastic#35268) [CCR] Forgot missing return statement, SQL: Fix null handling for AND and OR in SELECT (elastic#35277) [TEST] Mute ChangePolicyForIndexIT#testChangePolicyForIndex Serialize ignore_throttled also to 6.6 after backport Check for java 11 in buildSrc (elastic#35260) [TEST] increase await timeout in RemoteClusterConnectionTests Add missing up-to-date configuration (elastic#35255) Adapt Lucene BWC version SQL: Introduce Coalesce function (elastic#35253) Upgrade to lucene-8.0.0-snapshot-31d7dfe6b1 (elastic#35224) Fix failing ICU tests (elastic#35207) Prevent throttled indices to be searched through wildcards by default (elastic#34354) ...
pgomulka
pushed a commit
to pgomulka/elasticsearch
that referenced
this pull request
Nov 13, 2018
Added new SQL CLI logo representing the Elastic logo "painted" with "Elastic" words, "SQL" under the logo and version on the last line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new logo for the SQL CLI representing the Elastic logo "painted" with "Elastic" letters.